GithubHelp home page GithubHelp logo

Parameter case sensitivity about formio-php HOT 5 CLOSED

formio avatar formio commented on May 1, 2024
Parameter case sensitivity

from formio-php.

Comments (5)

travist avatar travist commented on May 1, 2024

Thanks @rmckeel. I responded to the PR. Please let me know if my proposal would fit your needs.

from formio-php.

rmckeel avatar rmckeel commented on May 1, 2024

@travist Just wanted to mention, I did respond to the PR. Let me know what you think about the possibility of additional formatting / PHP documentation in that file as a new PR.

from formio-php.

travist avatar travist commented on May 1, 2024

@rmckeel sorry about that. I was waiting for an update to the PR to accept it. If you don't mind, would you make that change and then submit an update to the PR? That way I don't have to go through the trouble of pulling in your branch, making the change, and then testing it on my end. Since you already seem to have a test case, it would be much easier on me if you would make the change to the existing PR. I will then pull it in.

from formio-php.

rmckeel avatar rmckeel commented on May 1, 2024

@travist Makes sense, I'll see what I can do there for the new PR in the next few days. Thanks!

from formio-php.

rmckeel avatar rmckeel commented on May 1, 2024

@travist I made a 'minimal change' PR that should work to fix the problem, but not adjust code style / etc. If you're interested in our code style / consistency / commenting updates, let me know and I can make another PR. No worries if you're not interested.

I'll close since PR can stand on its own.

Thanks!

from formio-php.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.