Comments (7)
Yeah I dont think we should not process the -class
prop — too many valid use cases would be impossible. Instead I think we might have 3 options:
- Make an exception for
$reset
, don’t treat it like a variable - Educate people to use the
__raw__inputClass
prefix - Come up with a new token other than the dollar-prefixed
$reset
from formkit.
Honestly, 3 seems like the most sensible thing, and now's the time to do it. some options:
%reset
_reset
!reset
@reset
<-- this one feels sass / tailwind like.
from formkit.
One small sticking point with those is only _reset
is a valid quoted object key in JS:
{
$reset: true, // ✅ valid
_reset: true, // ✅ valid
!reset: true, // 🚫 not valid
%reset: true, // 🚫 not valid
@reset: true // 🚫 not valid
}
Of course you could quote any of the above invalid ones, but it takes something away from the fluidity and legibility when you have to do that.
from formkit.
Wondering if it might be best to just call $reset
a reserved word.
from formkit.
Reserving $reset
feels reasonable in light of the above. I’m in favor.
from formkit.
As long as it's consistent between the Vue component and the schema, I think this will be ok. $reset
seems like it could be a relatively common collision within schema — I could see people using it for functions or other things — so we might consider ways to make it clear that it is a reserved word.
from formkit.
Ok, this is implemented for all -class
and fooClass
attributes. Caveat, it does not work for the classes
prop which will require the prefix: __raw__classes
from formkit.
Related Issues (20)
- Auto-import common types in Nuxt (like `FormKitNode`) HOT 6
- Can't unselect option by click when I searched for it HOT 1
- Taglist options wrong position when searching HOT 3
- Type error for attribute that is used to set inital value(value) HOT 8
- Dropdown Popover: Non-text id leads to "is not a valid selector" HOT 2
- Performance when loading hundreds of inputs HOT 2
- Mask does not fulfill browser's autofill
- Autocomplete input doesn't update its options correctly HOT 3
- Custom @remove-icon-click function doesn't override native remove handler HOT 6
- Datepicker cannot parse escaped tokens
- i18n - add language - Macedonian HOT 1
- Form flickers between valid and invalid state while user is typing HOT 2
- Mask Input, manually inputting non ASCII characters remains displayed HOT 3
- Togglebuttons: Certain ARIA roles must be contained by particular parents [accessibility] HOT 3
- Togglebuttons: Elements must only use supported ARIA attributes & Required ARIA attributes must be provided [accessibility] HOT 2
- [Autcomplete] Keep already fetched options displayed instead of showing "loading" section HOT 1
- Mask removes fractional separator HOT 1
- Togglebuttons: <li> elements must be contained in a <ul> or <ol> [accessibility] HOT 2
- Autocomplete build issue when upgraded from 0.122.16 to 0.123.1 HOT 2
- Taglist-Options flying in with AutoAnimatePlugin HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formkit.