GithubHelp home page GithubHelp logo

Comments (3)

dbroemmel avatar dbroemmel commented on July 19, 2024

I think that's similar to #153. And your change appears to be much shorter than my proposed solution, so I'd vote for that. I'd hope my proposed changed test still makes sense.

from fprettify.

AlexanderRichert-NOAA avatar AlexanderRichert-NOAA commented on July 19, 2024

Do you have a PR set up for your solution yet? If not, I can put one in, and then if you're willing to help contribute testing to that, that'd be great.

from fprettify.

dbroemmel avatar dbroemmel commented on July 19, 2024

#154 is my uglier fix. The test is pretty basic, I've simply adjusted the existing one to catch this case as well I believe. But I've also seen in #127 that the tests are going to be changed?

from fprettify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.