500 Error with Tags about selfoss

[tobalsan]

tags definitely aren't working

going to http://my.ho.st/tags returns a blank page. No error message at all, even in debug mode.

[SSilence]

Thats a really strange error. It seems the $this->view is not available. But in the constructor of the parent class (BaseController) it will be instantiated. What happens if you add
$this->view = new \helpers\View();
between the $html and foreach?

[tobalsan]

In tags controller:

/**
     * returns all tags
     *
     * @return void
     */
    public function renderTags($tags) {
        $html = "";
        $this->view = new \helpers\View();
        foreach($tags as $tag) {
            $this->view->tag = $tag['tag'];
            $this->view->color = $tag['color'];
            $html .= $this->view->render('templates/tag.phtml');
        }

        return $html;
    }

still no luck (same blank page, no error log)

i tested it on php5.4 and 5.3 btw

[vincebusam]

When I try that, I get two sets of tags on the home page, one where they look like they should go, and another on the very upper-left side disrupting the layout. Using Chrome.

[vincebusam]

For some reason, the framework was calling tags() twice, libs/f3/base.php:1147 and libs/f3/base.php:1164. Here's a hack to make it only return once.

    /**
     * returns all tags
     *
     * @return void
     */
    public function renderTags($tags) {
        $html = "";
        if (!$this->view) {
            $this->view = new \helpers\View();  
            return $html;
        }
        foreach($tags as $tag) {
            $this->view->tag = $tag['tag'];
            $this->view->color = $tag['color'];
            $html .= $this->view->render('templates/tag.phtml');
        }

        return $html;
    }

[SSilence]

I don't have an idea why this happens. When you watch your network communication, how often will be the tag refresh be executed?

Tag and Source refresh was changed yesterday. Can you retest this issue?

Do you have a special server configuration?

[vincebusam]

No luck. This is with PHP 5.3.2, stock Ubuntu 10.04 install.
Looking deeper into the backtrace, it happens when it's initializing the Tags Controller, even though the backtrace says it's calling ->tags(). Certainly very strange.

        $tagsController = new \controllers\Tags();

[SSilence]

Waaahh, I think I found the bug. Please test the newest version from master branch.

The name of the controller class Tags was the same as one function. The first letter of the function was lowercase but on some systems the function was interpreted as constructor. This constructor overwrites the constructor of the parent class which instantiates the view object. Crazy bug, I'm not sure why this happens on some systems and on others not.

Please reopen if problem still exists.

[vincebusam]

That fixes it for me. Thanks!