GithubHelp home page GithubHelp logo

Comments (4)

colin-axner avatar colin-axner commented on August 14, 2024 1

Improvement Suggestion: Add a mapping from a string to account address. This way users simply specify a "name" of the account they would like to spend from instead of an address similar to how go-crypto implements their keybase. But this may be a functionality that should be done by wallet and not in the CLI

from plasma-mvp-sidechain.

colin-axner avatar colin-axner commented on August 14, 2024

Further suggestions:

  • Add a keys command that has the following subcommands: add, delete, import, export, list, update

  • Add a way for users to recover their keys by saving a seed

  • As per above, add a mapping from a string to address so users can simply specify a key name rather than an address

  • Add a cache (db) for storing confirmation signatures that are generated or received. (Maybe this should be with plasmad since that is where the confirm sig would be recieved?)

  • Have the sign command prompt the user asking if they would like to finalize any of their pending txs. Should iterate through each displaying relevant information (time included in plasma block, value, send to addr)

  • Add a command to display pending txs (txs that haven't had a confirm sent, and/or have a finalization time less than that required for security)

  • Add a broadcast confirmation signature command. Should send to node address specified

  • Add a query command with relevant subcommands (block, txs, balance, info, deposits)

  • Add a eth command for all rootchain related commands. Checking on status of exits (time left). Maybe add commands for interacting with rootchain (or perhaps this better left for a wallet?)

  • Ensure all commands have adequate documentation when using -h. Flags should include example usage

  • Spending utxos should be as simple as possible, should be similar to:
    plasmacli spend <to> <amount> <account> --fee

Default use of spend should be to send to one address, and send whatever is leftover in the utxo back to oneself. We should add in different flags or perhaps a different command for spending to two different addresses.

I think it is important we don't add in a command for automatically sending confirmation signatures upon eth finalization time period, this would be predictable behavior and it wouldn't be that difficult to feed a node wrong info about eth chain for a few minutes.

from plasma-mvp-sidechain.

colin-axner avatar colin-axner commented on August 14, 2024

Update plasmacli keys list to display better given a long account name

from plasma-mvp-sidechain.

colin-axner avatar colin-axner commented on August 14, 2024

When adding broadcasting confirm sigs, consider adding SpendFinalized field to the input that is spent in the transaction

from plasma-mvp-sidechain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.