Comments (5)
Already done on my PR lol. Sends "deposit not final" along with how many blocks must pass before it is finalized. Of course from client side this is just an approximation since they may see a different chain than validator, but still useful info
from plasma-mvp-sidechain.
When spending a deposit if presumed finality has not passed, an error message of "deposit not final" should be returned instead of "deposit does not exist"
from plasma-mvp-sidechain.
When trying to spend a tx signing with the wrong key I get this error:
{"codespace":"handlers","code":1,"message":"input, [(0.0.0.0) Tu\ufffd\ufffd\u0001\ufffd;\ufffd\ufffd$\ufffduN(h۸)\ufffd:], does not exist by owner %!!(MISSING)x(MISSING)"}
Should replicate this error msg later, and adjust where it is being returned to be more clear
from plasma-mvp-sidechain.
Strange, why would it break on 0.0.0.0
not existing (Im assuming that this is second input, and u mis-signed on first input)? Looks like it's just a bad error msg overall and we need an "incorrect signature" error msg to be returned
from plasma-mvp-sidechain.
I think what might have occurred is since I signed with the wrong key, the utxo returned a nil position because it didn't exist in the mapping, causing the error message above
from plasma-mvp-sidechain.
Related Issues (20)
- Add a Query object using SDK implementation
- Add a way to broadcast signatures onchain HOT 3
- Reformat cli list keys cmd
- New Int Type HOT 1
- [Cobra] Unwanted help messages HOT 2
- Update Errors HOT 2
- Make SDK Rootchain module
- Rename output store
- Update to go doc style HOT 1
- Add ability to query for confirmation signatures HOT 1
- Add --verbose flag HOT 1
- Finality check for the cli HOT 1
- Add helper funcs in store/query
- RemovePosition in outputStore has implementation bug
- Change structure of store/
- Better Tx Decoder HOT 3
- Remove ReplayNonce from DepositMsg
- Bug in plasmad home directory HOT 1
- Add cli status commands
- GetUnspentFromWallet panic's on unspent deposits
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plasma-mvp-sidechain.