[Bug] V8 Import from older version is broken. about browser-extension

[erosman]

There is actually a bug in the pattern conversion. I am going to fix it.

[ericjung]

and wrote it to the disk

https://github.com/foxyproxy/firefox-extension/blob/master/src/scripts/background.js#L14

There is no reason to write to disk unless the background page can be unloaded? It can be kept in a 500 element in-memory array.

there were never any complaints about performance of 7.x. You are sacrificing excellent functionality — why people choose FoxyProxy— to maximize performance of an edge case. Logging is an edge case that is rarely used. But when it is used, users should be able to correlate a URL with a proxy that loads it. If I have 15 or more proxies, and multiple URLs to track down which proxy loaded it, the current log is useless because I will spend an inordinate amount of time and have to take notes on which proxy loads which url.

[ericjung]

Thank you. Do you have any wildcard patterns? Did they import successfully?

[agamotto]

Not sure if related or not, but with extension upgrade to 8.0. my configured proxies are gone. Where can I find them and import them?

[erosman]

Not sure if related or not, but with extension upgrade to 8.0. my configured proxies are gone. Where can I find them and import them?

Was the upgrade for FoxyProxy Basic on Firefox?
If so, it would be a different issue.

[agamotto]

Not sure if related or not, but with extension upgrade to 8.0. my configured proxies are gone. Where can I find them and import them?

Was the upgrade for FoxyProxy Basic on Firefox? If so, it would be a different issue.

Yes it was on Firefox (latest 117.0.1), it just updated FoxyProxy Basic automatically but configurations were gone.

[erosman]

Do you have a backup?

[TriMoon]

@ericjung
Thank you. Do you have any wildcard patterns? Did they import successfully?

Yes i have many, and no they didn't import successfully as i mentioned in the OP...

---

@erosman

The error says it all. The regular expression has errors. Please fix the error and try again. [0-9] requires a repeat value.
FoxyProxy v8.0 checks the patterns for errors before saving them (previous versions didn't but failed later when matching).

The regExp in the backup has NO-ERRORS, it is the translation while importing that has error...

FoxyProxy originally supported full URL matching patterns. Due to some API limitations, it was later changed to host matching patterns in the Firefox version. FoxyProxy v8.0 supports full URL patterns matching in v8.0 again.

I understand that's why i suggested you to split into parts for the user and your code.
That way you can both import backups from the current old version AND allow users to explicitly enter regExp for the page parts.

• [!Important]
  I think you need to separate your patterns into protocol, hostname, and eventual path patterns in your new version, and import into the hostname patterns only. The protocol part could be made a select-list, while the other two definitely need separate input boxes and code to check only those parts of the URL...

Your code NEEDS 3 separate values to correctly check the URL: https://some.web.site:80/page1/index.html

1. Protocol part = https in example above.
   This can be a string or enum in your code.
   The String is in case you will allow users to enter freestyle text fe. ws instead of the standard http or https, otherwise you can make it an enum only that the user can select from a drop-down listing.
2. Host part = some.web.site:80 in example above.
   This can be a string or regExp.
   This is to be able to properly import previous backups which only supported hostnames.
3. Path part = page1/index.html in example above.
   This can be a string, regExp or null.
   This will be the page address after the hostname.
   This is to be able to properly import previous backups which only supported hostnames.

Without the above you won't be able tobe "backward-compatible"...

[TriMoon]

Please keep in mind the old-rules, in backup, i gave in OP because people WILL have used that kind...

I'll be waiting to pull the changes and test on my side 👍

[erosman]

Repo updated with a fix (fingers crossed).

[erosman]

Oops.. there was a typo... repo updated

[TriMoon]

👍 Seems it's fixed now, no errors while importing from older version backup...

Will need to check all rules later when i have time, but looks good so far 👍

---

Just one note though, unrelated to this issue:
Can the LOG screen please show the name of the proxy used instead of it's address?
Name of the proxy the user has set is much more useful, maybe also color the lines using the color of that proxy...
👍

[erosman]

The log is generated from a separate independent process which doesn't have access to the saved data. It prints direct from the data provided by Firefox.

It would also be easier to correlate the log with external network monitors.

[ericjung]

The 7.x and earlier versions display the name of the proxy and it’s colors in the log, as I remember.

[erosman]

Updated: (correction)

v7.* logged every connection at the time of matching, and kept it in RAM in the background script. In MV3 background script gets unloaded.

v8.0 has a live log. It starts when the Options page opens and stops when the page is closed.

Please also note ...

Proposal: Provide documentation and reporting for browser's slow extension warnings
https://github.com/w3c/webextensions/issues/456

https://searchfox.org/mozilla-central/source/dom/ipc/ProcessHangMonitor.cpp#63-86
"EXTENSION NAME" is slowing down Firefox. To speed up your browser, stop that extension. Learn more

https://source.chromium.org/chromium/chromium/src/+/main:extensions/browser/warning_set.cc;l=71-80;bpv=1;bpt=1
This extension is slowing down Google Chrome. You should disable it to restore Google Chrome's performance.

[erosman]

In MV3 background page will be unloaded.

https://github.com/foxyproxy/firefox-extension/blob/a3598e1c7f0237ee50e8a13a59dec265462c38a6/src/scripts/log.js#L33-L41

runtime.getBackgroundPage()
Retrieves the Window object for the background page running inside the current extension. If the background page is non-persistent (an event page) and it is not running, the background page is started.