mupdf breaking changes about avitab

[fpw]

Thanks for the report, I'll consider the mupdf update in one of the next versions.

[fpw]

Thanks, I want to clean up the CMake files to use proper library detection one day and will remember to fix this as well.

PS: I suggest to start with the standalone version, it runs as a normal native program without X-Plane and is faster to restart, easier to debug etc.

[kbrandwijk]

It runs! Thanks for your assistance! Now on to the source code 🎉
So as far as I'm concerned, this can be closed.

[fpw]

• Increased required mupdf version to 1.14.0
• Added framework search path for OS X CMake
• Fixed lambda warnings so -Wall works on newer OS X compilers

[kbrandwijk]

I also get build errors on 1.13.0 (when building mupdf). I know it's not your fault, but maybe you ran into that?

CC build/release/platform/gl/gl-main.o
platform/gl/gl-main.c:1677:2: warning: implicit declaration of function
      'glutSetOption' is invalid in C99 [-Wimplicit-function-declaration]
        glutSetOption(GLUT_ACTION_ON_WINDOW_CLOSE, GLUT_ACTION_GLUTMAINL...
        ^
platform/gl/gl-main.c:1677:16: error: use of undeclared identifier
      'GLUT_ACTION_ON_WINDOW_CLOSE'
        glutSetOption(GLUT_ACTION_ON_WINDOW_CLOSE, GLUT_ACTION_GLUTMAINL...
                      ^
platform/gl/gl-main.c:1677:45: error: use of undeclared identifier
      'GLUT_ACTION_GLUTMAINLOOP_RETURNS'
        glutSetOption(GLUT_ACTION_ON_WINDOW_CLOSE, GLUT_ACTION_GLUTMAINL...

[kbrandwijk]

In the meantime, maybe you could at least update the wiki to reflect this.

[fpw]

These errors indicate that you're compiling with X support. Try passing HAVE_X11=no and HAVE_GLUT=no to mupdf's configure parameters.

[kbrandwijk]

Great, thanks for your help! Worked like a charm. Searching for HAVE_GLUT actually brought up those instructions :) The only other thing is that I had to turn off -Werror, because of a number of [-Wunused-lambda-capture] warnings, but now it builds like a charm. I can finally start testing now.

[fpw]

Good luck! I hope it's not too hard to dig into the undocumented code. Feel free to ask any questions about the architecture etc.
I updated the Wiki to mention the supported mupdf version.

[kbrandwijk]

Hmmmm... only one error left:

[100%] Linking CXX shared library AviTab.xpl
ld: framework not found XPLM

I did update CMakeLists.txt to add link_directories("/opt/XSDK/Libraries/Mac") because I'm on Mac, but that didn't help...

Any suggestions?

[fpw]

If I remember correctly, I didn't find a solution to that and ended up copying XPLM.framework to /Library/Frameworks/. If you find a better a solution to use a non-system path, feel free to patch the CMake file.

[kbrandwijk]

Adding an explicit -F/opt/XSDK/Libraries/Mac worked:

elseif(APPLE)
target_link_libraries(avitab_plugin
    ${CommonLibs}
    avitab_env_xplane
    "-F/opt/XSDK/Libraries/Mac -framework XPLM"
)

I'll make a separate PR for 'making it build on Mac' :D