GithubHelp home page GithubHelp logo

Edit messages about oasis HOT 4 OPEN

christianbundy avatar christianbundy commented on May 8, 2024
Edit messages

from oasis.

Comments (4)

cinnamon-bun avatar cinnamon-bun commented on May 8, 2024 1

We have a responsibility to let users know this is only cosmetic; their old message will still be available in the feed. Otherwise they might think that e.g. editing away personal information will be effective.

But overall I'm excited to try this! I have a lot of questions but that doesn't mean I'm opposed:

This would be the first client using the edit plugin? https://github.com/fraction/ssb-edit/network/dependents

Is there a spec for these edit messages? The ssb-edit code looks like a view for indexing them but doesn't describe the format for publishing them, and the expected semantics around them. Has this format been discussed w/ the community?

What types of messages can be edited?

Can anyone edit a message or is it limited to the original author?

I think the index uses the last edit message in the order provided by flume. If using ssb-ooo, could the messages be out of order so that the wrong one is chosen?

It looks like editing is done by publishing a type: edit message which is expected to supersede the original. Those messages will be invisible in most clients. Could it be more backwards-compatible to publish the edits as regular message types, with an additional key like replaces: "%abc... ", so that they will visible in older clients (graceful degradation style).

Some other message types are already editable e.g. the last one is considered to supersede the previous ones (about, gathering, contact). Do they have a uniform format for referring back to the thing they're replacing?

(sorry for the wall of questions, this feels like an ecosystem-level decision to make with care)

from oasis.

jedahan avatar jedahan commented on May 8, 2024

How about a delayed post plugin? Make it all client-side. One implementation could post to your local feed, but filter that message in gossips until post time + (1 hour? 15 minutes?). If a post is edited, roll back, recalculate hashes, and re-add to feed.

from oasis.

christianbundy avatar christianbundy commented on May 8, 2024

How about a delayed post plugin?

We could safe it as a pending draft, but once you introduce a message to the flumedb views you can't remove it without rebuilding all of your indexes. What do you think about having the ability to edit?

from oasis.

cinnamon-bun avatar cinnamon-bun commented on May 8, 2024

How about a delayed post plugin? Make it all client-side. One implementation could post to your local feed, but filter that message in gossips until post time + (1 hour? 15 minutes?). If a post is edited, roll back, recalculate hashes, and re-add to feed.

If the user posts and then turns off their computer, their message won't get published. This could be ok if the delay is very short (10 seconds?) and there's clear communication about this in the UI.

from oasis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.