GithubHelp home page GithubHelp logo

Comments (7)

romanrev avatar romanrev commented on August 23, 2024 2

thanks for the hint with checking the function is defined, it was empty indeed! I've sourced the ~/.config/fish/conf.d/done.fish manually and it has obviously defined it correctly. I am guessing fisher is sourcing the new plugin files automatically once it is updated, but obviously that doesn't happen in the multitude of terminal tabs I have open on my computer 😁 Thanks again for hand-holding me, I am closing this ticket now

from done.

ammgws avatar ammgws commented on August 23, 2024 1

I believe fisher is meant to source the new files automatically, perhaps try asking there?
https://github.com/jorgebucaran/fisher/blob/b2c317a2aecb69727da9c2b88c730bb5537e2d26/functions/fisher.fish#L173-L174

Try running functions __done_humanize_duration, it should return the definition of the function, otherwise the currently loaded done.fish is old.

I recommend just spinning up a new shell for now.

from done.

ammgws avatar ammgws commented on August 23, 2024

Looks like you're on an old version of done, since that function was internalised in the code quite a while ago.

The error is probably because that package was renamed to humantime: https://github.com/jorgebucaran/humantime.fish/

Anyway, updating done should resolve your issue

from done.

romanrev avatar romanrev commented on August 23, 2024

thanks for your prompt feedback @ammgws ! But I have already updated done, or so I thought at least, by running fisher update franciscolourenco/done - several times already in fact. Could you tell what is the way to confirm the update has actually happened, except for observing the output?

➤ fisher update franciscolourenco/done
fisher update version 4.3.0
Fetching https://codeload.github.com/franciscolourenco/done/tar.gz/HEAD
Installing franciscolourenco/done
           /Users/roman/.config/fish/conf.d/done.fish
Updated 1 plugin/s

thank you!

from done.

romanrev avatar romanrev commented on August 23, 2024

ok, I've downloaded the done.fish file from GH directly and compared it to the one installed in my ~/.config/fish/conf.d/done.fish - they look identical:

➤ diff -u ~/.config/fish/conf.d/done.fish /tmp/done.fish
<nil>

I wonder if somehow the old done is still used in my shell? Do you know if there is a way to ensure the plugin code is reloaded in memory after update?

from done.

franciscolourenco avatar franciscolourenco commented on August 23, 2024

For future reference, you can also get the loaded version of done with

echo $__done_version

from done.

romanrev avatar romanrev commented on August 23, 2024

great to know, thank you!

from done.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.