Comments (9)
@Perlence can you update goreq and run the race detector again?. Seems like is something else https://github.com/franela/goreq/blob/master/goreq.go#L314
from goreq.
I've updated goreq so the master is 8f5efc2. Unfortunately warning's still there:
Write by goroutine 14:
github.com/franela/goreq.Request.Do()
/home/ubuntu/.local/go/src/github.com/franela/goreq/goreq.go:323 +0x6ff
from goreq.
@Perlence We found the issue. We'll be fixing this shorty. It won't affect your code unless you are specifying different maxRedirects per request.
from goreq.
Hi, I'm seeing the same issue - would love a fix just to clean up the warning.
from goreq.
@rhd we'll fix it shortly.
from goreq.
I have independently rediscovered this race condition in my application. I'm at head, eg 72c51a5
Note also that changing the Makefile to run go test --race finds other race conditions as well.
from goreq.
Yes, there are some race conditions they all come from using DefaultClient and allowing functionallity that should require a new client.
I believe we should add a Client abstraction to goreq and make these things configurable at a global level and allow to create new goreq clients.
from goreq.
any progress on this over the weekend?
from goreq.
@rrh I haven't had time to check this, but those races are hard to tackle without breaking backwards compatibility, that's a bummer.
from goreq.
Related Issues (20)
- Request Query Strings are normalized to small letters HOT 3
- Support for Custom Transport? HOT 2
- Add a DoByClient method
- json not being passed to request HOT 1
- missing license HOT 1
- Concurrency issue: call .Do() in different goroutines replace CheckRedirect of singleton client HOT 1
- using goreq with appengine HOT 1
- when assign client cookiejar not attached
- How to send POST application/x-www-form-urlencoded (NOT JSON) HOT 7
- Individual debug flags for header and body?
- DNS resolve time out.
- how to post json to sever
- How to request https via proxy
- FromJsonTo() doesn't work
- Empty URI in response HOT 1
- Timeout unit tests fail
- unknown http.Transport field 'ProxyConnectHeader' in struct literal HOT 4
- can't call FromJsonTo after ToString() method has been called
- Possible for a tag/release of the "stable"
- 301 302 go func(){}() error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goreq.