I added an event after field edition, what do you think ? about datatable

[hetal1110]

Is there any way to get selected rows in Datatable?

But how to get row Ids, that is selected?

What is the Event to capture selected rows?

Thanks in Advance…

[sanjay-hercules]

@hetal1110 you can get selected rows of report having checkbox as mentioned below:

		onload: function() {
                       // add a button to report
			frappe.query_report.page.add_inner_button(__("Get Selected"), function() {
				var selected_rows = [];
				$('.dt-scrollable').find(":input[type=checkbox]").each((idx, row) => {
					if(row.checked){
						console.log("*** selected row id : " + idx);
						selected_rows.push(frappe.query_report.data[idx]);
					}
				});
			});
		},

[AndyOverLord]

Hi @melBoh, thank you very much. I think it's working real well as I have used it to enabled a feature of editing inline and update it in the database. I wonder why it's still not merged to the repository.

If I make the changes on my own, how to prevent the changes be override with next frappe version updates.

[kevinpthorne]

why this is still open? Can a PR be made for this?

[kevinpthorne]

Actually, I found using the setValue function when setting the datatable's getEditor return object provided the same functionality.

For example (using Frappe Controls)

	getEditor: function(colIndex, rowIndex, value, parent, column, row, data) {
            // colIndex, rowIndex of the cell being edited
            // value: value of cell before edit
            // parent: edit container (use this to append your own custom control)
            // column: the column object of editing cell
            // row: the row of editing cell
            // data: array of all rows

            const control = frappe.ui.form.make_control({
                parent: parent,
                df: {
                    label: '',
                    fieldname: doctype,
                    fieldtype: 'Link',
                    options: doctype
                },
                render_input: true,
                only_input: true,
            });

            let oldValue = '';

            return {
                // called when cell is being edited
                initValue(value) {
                    control.input.focus();
                    control.input.value = value;
                    oldValue = value;
                },
                // called when cell value is set
                setValue(newValue) {
                    // ----------- Do whatever is needed here.
                    control.input.value = newValue;
                },
                // value to show in cell
                getValue() {
                    return control.input.value;
                }
            }
        }

[azharumar]

I've hit a strange roadblock.

Inline editing works in Report Builder, but calculated fields are not possible.
Calculated fields are possible in script editor, but inline editing is not possible.

[kevinpthorne]

I've hit a strange roadblock.

Inline editing works in Report Builder, but calculated fields are not possible.
Calculated fields are possible in script editor, but inline editing is not possible.

Editing a calculated field goes against their purpose. I would make it whatever type it should be and do the calculation manually. Alternatively, you can make a hidden calculation field and copy the value over to the editable field.

[azharumar]

I've hit a strange roadblock.
Inline editing works in Report Builder, but calculated fields are not possible.
Calculated fields are possible in script editor, but inline editing is not possible.

Editing a calculated field goes against their purpose. I would make it whatever type it should be and do the calculation manually. Alternatively, you can make a hidden calculation field and copy the value over to the editable field.

Obviously! I wouldn't want a calculated field to be editable. Instead, I have a report where both type of columns are needed - one for calculated and another for inline editing.