fraterrisus / dnd5e Goto Github PK

There's a whole host of issues with using ActiveRecord's where to query boolean columns on SQLite-backed databases. At the moment this prevents our spell filters from working.

At the moment the app totally lacks any sort of user/permission model. Look into cancancan or something.

It would be nice to be able to deploy this code out on the public internet with at least basic user/pass protection on it, given that we're in the world of virtual tabletop gaming due to the pandemic.

Permissions are probably admin / DM / player or something like that; consider just allowing fine-grained permissions on all obvious actions (see Character List; create new Character; delete Character; edit Character). For extra credit, allow an account to be tied to one or more Characters on the list.

Bootstrap 5 is still in beta as of the time of this writing. Upgrading will be significant; v5 gets rid of the dependency on jQuery, so at the very least all of our event handlers will switch from using $(element).on to element.addEventListener.

It's still under development in Bootstrap 5 beta so maybe hold off on this for a while?

Create a "add spell" function in the user interface. It should be able to display a file from /public/spells in order to make it easier for a human to enter the spell data. Don't forget to include the join with caster_class.

As a followup, modify the spell importer to parse the HTML and automatically add entries to the spells table.

Many (if not most) places in our AJAX code uses .catch to catch errors when fetching dynamic data, but usually it just pops a browser alert. Bootstrap gives us Toasts, let's use them.

See https://github.com/TheDataRogue/dnd-5e-spells

Naming database fields name was dumb, because Object#name already exists in ruby. Write migrations to fix this.

At the moment the most notable manifestation of this is in "new object" modal dialogs... when you send a Class into form_with, and then call form.field(:name), you get the name of the class.

1. Write some damn unit tests for the ruby code.
2. Figure out how to test the javascript.

This is the last remaining use of #bootstrap_modal, which should probably be retired (or turned into a partial)

Bootstrap 5 is out of beta; complete the upgrade and cross your fingers that not much needs to be done.

At the moment this is an integer field that doesn't do anything. Figure out how to make it useful on the Combatants page.

Probably we'll want to use Spell#components as a model, especially the way we dynamically broke it out into :somatic, :verbal, etc. There are kind of a lot of possible effects, though.