Case insensitive search about pyxero

[jacobg]

I hacked around it by doing this:

def _search_contact_name(xero, name):

    def _filter(*args, **kwargs):
        uri, params, method, body, headers, singleobject = xero.contacts._filter(*args, **kwargs)
        params = {'where': 'Name.ToLower()=="%s"' % name.lower()}
        return uri, params, method, body, headers, singleobject

    return xero.contacts._get_data(_filter)()

Perhaps there could be a official solution which offers direct access to the where parameter.

[jacobg]

I just saw there's a long standing pull request on this waiting to be accepted by the "powers that be":

#54

[aidanlister]

I support a .raw() method if you want to provide a patch

[jacobg]

Would it look like this?

    def _raw(self, params, headers=None):
        uri = '/'.join([self.base_url, self.name])
        return uri, params, 'get', None, headers, False

[aidanlister]

I would expect the userland syntax to be .filter(raw='xxx') or .rawfilter() maybe

[jacobg]

You mean to enhance the existing filter? What about just allowing a 'where' argument to be added to filter to override generating inside the filter from the other kwargs?

[aidanlister]

Yeah I was thinking it could be used to supplement, I think if we add it to the end at least the behaviour is consistent and can be documented.

[aidanlister]

This is now implemented via filter(raw='Contact.Name.ToLower().Contains("abc")')