GithubHelp home page GithubHelp logo

Comments (18)

yorikvanhavre avatar yorikvanhavre commented on June 2, 2024 2

My idea was simply a way to change, say, the 5 or 6 basic standard them colors (window fore/background, selected fore/background, etc). Indeed it's not enough for proper theming, but it could be useful to some.

Note that this can 100% be done in an addon. No need to be part of Core. Such an addon could simply offer a preference page to set the colors, build a qss from it, and apply that qss...

from freecad-addons.

adrianinsaval avatar adrianinsaval commented on June 2, 2024 1

I don't see a compelling use case for fine control of every single UI element like the tree background, stuff like the colors in sketcher I understand and those are therefore configurable, stuff like this is just more maintenance burden to satisfy a niche whim from a fraction of users so I would like to close this issue.

We already have trouble now because some colors are set using preferences, others using stylesheets, and a few are burried in code, adding more to the mix is not going to help.

Consider developing this as an addon instead.

from freecad-addons.

MisterMakerNL avatar MisterMakerNL commented on June 2, 2024 1

I can remember when I was a young boy we had windows 3.1 and we could change all colors.
One day I changed everything to black on the school computer.
I don't think they liked that.
I also don't think giving normal users these powers is a good idea.

from freecad-addons.

adrianinsaval avatar adrianinsaval commented on June 2, 2024 1

An add-on for this would be a perfect solution. For the core I think we should reject this request

And I don't think the issue tracker is for add-on requests

from freecad-addons.

yorikvanhavre avatar yorikvanhavre commented on June 2, 2024

This is a more complex issue than it seems because since there are many ways to set colors in a Qt app, care must be taken with what overriding what. But this seems like a good idea, in case no css style is used, an easy, default one could be done with a simple dialog like this

from freecad-addons.

luzpaz avatar luzpaz commented on June 2, 2024

I think finetuning as an option in FreeCAD core is great. It will make us consider a better approach to standardizing how we set colors (and organize the hacks that have been made to FC in the past on this issue).

from freecad-addons.

adrianinsaval avatar adrianinsaval commented on June 2, 2024

I disagree, I think this would just be adding more unnecessary complexity to the pile and make it even harder to make good themes. More colours as preferences is undesirable IMO. No compelling use case was provided for changing the tree view background for example.

from freecad-addons.

luzpaz avatar luzpaz commented on June 2, 2024

Ok, I concede. Addon is a fair compromise. I'll transfer this to Addons repo

from freecad-addons.

luzpaz avatar luzpaz commented on June 2, 2024

@MisterMakerNL lets compile a list of settings that an addon like this would be able to manipulate?

Edit: this ticket may also overlap with FreeCAD/FreeCAD#6805

from freecad-addons.

MisterMakerNL avatar MisterMakerNL commented on June 2, 2024

Axeia has made a nice macro where you can see the preference colors: https://github.com/Axeia/FreeCAD-Color-Fetcher/tree/main

from freecad-addons.

luzpaz avatar luzpaz commented on June 2, 2024

Do you have a quick screenshot to share ?

from freecad-addons.

NXTler avatar NXTler commented on June 2, 2024

A ReadMe has been added to the project with a screenshot.

from freecad-addons.

luzpaz avatar luzpaz commented on June 2, 2024

What is left to do here ?

from freecad-addons.

NXTler avatar NXTler commented on June 2, 2024

The Color-Alterator is already great, to be honest. The only feature I miss is being able to set the color of backgrounds (from the model tree for example). Should I move this to the macro?

from freecad-addons.

luzpaz avatar luzpaz commented on June 2, 2024

Should i move this to the macro?

Can you clarify what you mean here ?

from freecad-addons.

NXTler avatar NXTler commented on June 2, 2024

Does this feature request still applies to FreeCAD, or should it be moved to the Color-Agragator?

from freecad-addons.

luzpaz avatar luzpaz commented on June 2, 2024

Probably moved to the Color-Aggregator

from freecad-addons.

NXTler avatar NXTler commented on June 2, 2024

Moved to Color-Aggregator, I close this issue for now.

from freecad-addons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.