After opening and closing a sketch without even touching anything the Body broke about freecad

[maxwxyz]

I even get an error just opening the file. I am pretty sure the pipe would not work with such a master sketch with multiple closed overlapping profiles.

[szimszon]

I even get an error just opening the file. I am pretty sure the pipe would not work with such a master sketch with multiple closed overlapping profiles.

When I open the file I see only this messages:

07:18:58  AttachEngine3D::calculateAttachedPlacement:InertialCS: inertia tensor has axis of symmetry. Second and third axes of inertia are undefined.
07:18:58  AttachEngine3D::calculateAttachedPlacement:InertialCS: inertia tensor has axis of symmetry. Second and third axes of inertia are undefined.
07:18:58  AttachEngine3D::calculateAttachedPlacement:InertialCS: inertia tensor has axis of symmetry. Second and third axes of inertia are undefined.

with

OS: Ubuntu 23.10 (XFCE/xubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37709 (Git) AppImage
Build type: Release
Branch: main
Hash: dd816a635ccacc39f29b1761c6ccfed21a90b646
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Hungarian/Hungary (hu_HU)
Installed mods: 
  * Defeaturing 1.2.2
  * lattice2 1.0.0
  * Curves 0.6.37
  * Ondsel-Lens 2024.5.6.01
  * fasteners 0.5.21

[szimszon]

I even get an error just opening the file. I am pretty sure the pipe would not work with such a master sketch with multiple closed overlapping profiles.

The modell is created with FreeCAD weekly builds all from the beginning.

I'm not using the entire object for the path just one edge from the Master sketch:

For the profile I have a separate sketch called OutputPipeSketch . It has no overlapping profiles.

The AdditivePipe works with this setup for me as you can see in this picture:

If this should not work at all then there is a second issue here as FreeCAD allows me to do it and it even works as expected.

The issue for me here is still if I open the MasterSketch then do nothing and close it the geometry references get screwed and my model broke.

If this is a result of a "not valid" MasterSketch it looks to me as a bad thing as my understanding of a master sketch is that I can draw any geometry in it without make it a valid closed and not overlapping pofiles for future references.

[szimszon]

After all my question is:

• Is FreeCAD not designed to handle an edge from a Sketch where multiple open and/or overlapping profiles are present for Pipe?
  • then it should inform the user about it
• If I don't do anything within a sketch not even clicking on anything then why recompute?
• If "not valid" sketch is used as a master sketch for future external references (which is a recommended way - as far as I know the recommendations) and it has a capability to screw geometry references only by opening and closing it, do it pose a big risk with complex projects? I needed aprox. 10 minute to fix my model after opening and closing the master sketch. (Any it is repeatable - if you open and close the master sketch it will broke my model again and again)

[szimszon]

Just checked with the latest weekly build:

OS: Ubuntu 23.10 (XFCE/xubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37730 (Git) AppImage
Build type: Release
Branch: main
Hash: 30f7f2688921e6e5242beaa9d71e0fdd844b20e3
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Hungarian/Hungary (hu_HU)
Installed mods: 
  * Defeaturing 1.2.2
  * lattice2 1.0.0
  * Curves 0.6.37
  * Ondsel-Lens 2024.5.6.01
  * fasteners 0.5.21

• I can load the file.
• AddtitvePipe works.
• I open MasterSketch.
• I close MasterSketch.
• AdditivePipe broken.

08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#DatumPlane.Support missing element reference vizlopo#Sketch ;g53;SKT;:H,E.Edge11
08:02:33  AttachEngine3D::calculateAttachedPlacement:InertialCS: inertia tensor has axis of symmetry. Second and third axes of inertia are undefined.
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch004.ExternalGeometry missing element reference vizlopo#Sketch ;g61;SKT;:H,E.Edge10
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch004.ExternalGeometry missing element reference vizlopo#Sketch ;g59;SKT;:H,E.Edge8
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch006.ExternalGeometry missing element reference vizlopo#Sketch ;g54;SKT.Edge47
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch006.ExternalGeometry missing element reference vizlopo#Sketch ;g41;SKT;:H,E.Edge12
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch006.ExternalGeometry missing element reference vizlopo#Sketch ;g36;SKT;:H,E.Edge14
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch006.ExternalGeometry missing element reference vizlopo#Sketch ;g19;SKT.Edge18
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch005.ExternalGeometry missing element reference vizlopo#Sketch ;g29;SKT;:H,E.Edge6
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch005.ExternalGeometry missing element reference vizlopo#Sketch ;g57;SKT.Edge50
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#AdditivePipe.Spine missing element reference vizlopo#Sketch ;g37;SKT.Edge34
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch007.ExternalGeometry missing element reference vizlopo#Sketch ;g48;SKT.Edge44
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch007.ExternalGeometry missing element reference vizlopo#Sketch ;g49;SKT.Edge45
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch007.ExternalGeometry missing element reference vizlopo#Sketch ;g50;SKT.Edge46
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch001.ExternalGeometry missing element reference vizlopo#Sketch ;g24;SKT.Edge24
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch001.ExternalGeometry missing element reference vizlopo#Sketch ;g27;SKT.Edge26
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch001.ExternalGeometry missing element reference vizlopo#Sketch ;g13;SKT.Edge3
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch001.ExternalGeometry missing element reference vizlopo#Sketch ;g31;SKT.Edge29
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch008.ExternalGeometry missing element reference vizlopo#Sketch ;g42;SKT.Edge35
08:02:33  <PropertyLinks> PropertyLinks.cpp(453): vizlopo#Sketch008.ExternalGeometry missing element reference vizlopo#Sketch ;g43;SKT;:H,E.Edge13
08:02:33  Invalid shape name ?Edge13
Clear constraints to external geometry
08:02:33  Invalid shape name ?Edge45
Clear constraints to external geometry
08:02:33  Invalid shape name ?Edge12
Clear constraints to external geometry
08:02:33  Invalid shape name ?Edge3
Clear constraints to external geometry
08:02:33  Invalid shape name ?Edge8
Clear constraints to external geometry
08:02:33  AttachEngine3D::calculateAttachedPlacement:InertialCS: inertia tensor has axis of symmetry. Second and third axes of inertia are undefined.
08:02:33  AttachEngine3D::calculateAttachedPlacement:InertialCS: inertia tensor has axis of symmetry. Second and third axes of inertia are undefined.
08:02:33  AdditivePipe: A fatal error occurred when making the pipe
08:02:33  AdditivePipe: A fatal error occurred when making the pipe

[maxwxyz]

@bgbsww is this related to TNP changes?

[szimszon]

The problem also present in version:

OS: Ubuntu 23.10 (XFCE/xubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37819 (Git) AppImage
Build type: Release
Branch: main
Hash: 2ca9b6ef8036d5fd808f01205b66eb0424059e21
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Hungarian/Hungary (hu_HU)
Installed mods: 
  * Defeaturing 1.2.2
  * lattice2 1.0.0
  * Curves 0.6.37
  * Ondsel-Lens 2024.5.6.01
  * fasteners 0.5.21

[bgbsww]

Yes, this is likely an external geometry issue in the TNP code that is triggered when closing a sketch.