Comments (9)
Looks like now we're expecting a whitespace character on either side of the thanks but we really just need a non-word character.
from camper-gitter-bot.
adding |\W
to first capturing group in this line will fix it I think, @ltegman can I do a PR?
from camper-gitter-bot.
word breaks created a lot of problems. Please don't use \W
or \b
from camper-gitter-bot.
@abhisekp just curiosity , how would using non-word metacharacter create problems?
from camper-gitter-bot.
@Dave1089 You may check the history https://github.com/FreeCodeCamp/camperbot/commits/6013edabcb34159501270cce4fec5b2f64f76133/data/rooms/RoomMessages.js
Previously, the regex was using \b
which had many false positives leading to falsely giving out points to known and unknown campers (unintended). 94e2558#diff-df3e5eba3a8c0d8a1bc5b0899e09041a
I fear the regex in the PR https://github.com/Dave1089/camperbot/pull/1/files#diff-df3e5eba3a8c0d8a1bc5b0899e09041aR48 might create the same issues.
from camper-gitter-bot.
@abhisekp I would like to get input from you how we should approach this issue of not validating non-word characters then
from camper-gitter-bot.
@ltegman @Dave1089 I suggest to not complicate the regex more than it already is.
Using anything other than whitespace is not so common case. There might be more false positives if any character other than a whitespace is used.
from camper-gitter-bot.
Okey
from camper-gitter-bot.
Closing as stale and possible wontfix
from camper-gitter-bot.
Related Issues (20)
- Disable Camperbot greeting or make it less frequent HOT 14
- remove /rollem HOT 11
- Add more 'thank you' phrases as as camperbot trigger words HOT 4
- Brownie Points bug: placing dots before 'Thanks' has no effect HOT 5
- remove about HOT 3
- remove echo HOT 3
- Make camperbot welcome people over DM HOT 9
- n/a
- Fix "arigatou" too "arigato" (Thank you in Japanese) HOT 1
- Update holler command to ignore usernames
- Update readme, to latest updates and remove unwanted/unused details.
- Should allow issue numbers without comment HOT 3
- bug - ignore brownies when in names HOT 1
- remove codingjobs from lists of rooms
- remove backend-challenges from list of rooms
- change .com -> .org
- Repeat thanks giving incorrect message HOT 1
- Limit CamperBot's thanks list to 1 or 2 people HOT 2
- Remove 'find' from triggering keywords HOT 1
- Add a "ban" command? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from camper-gitter-bot.