Camperbot fails to give points if there is a bracket before a "thanks" about camper-gitter-bot

[ltegman]

Looks like now we're expecting a whitespace character on either side of the thanks but we really just need a non-word character.

[da-way]

adding |\W to first capturing group in this line will fix it I think, @ltegman can I do a PR?

[abhisekp]

word breaks created a lot of problems. Please don't use \W or \b

[da-way]

@abhisekp just curiosity , how would using non-word metacharacter create problems?

[abhisekp]

@Dave1089 You may check the history https://github.com/FreeCodeCamp/camperbot/commits/6013edabcb34159501270cce4fec5b2f64f76133/data/rooms/RoomMessages.js

Previously, the regex was using \b which had many false positives leading to falsely giving out points to known and unknown campers (unintended). 94e2558#diff-df3e5eba3a8c0d8a1bc5b0899e09041a

I fear the regex in the PR https://github.com/Dave1089/camperbot/pull/1/files#diff-df3e5eba3a8c0d8a1bc5b0899e09041aR48 might create the same issues.

[da-way]

@abhisekp I would like to get input from you how we should approach this issue of not validating non-word characters then

[abhisekp]

@ltegman @Dave1089 I suggest to not complicate the regex more than it already is.
Using anything other than whitespace is not so common case. There might be more false positives if any character other than a whitespace is used.

[da-way]

Okey

[dhcodes]

Closing as stale and possible wontfix