CTRL + Enter doesn't work to complete challenges (RWD) about learn

[ekafyi]

Did someone already fix it? Ctrl + Enter (and even Option + Enter) works on my machine (Mac OSX 10, tested on Chrome, Firefox, Safari).

[Bouncey]

I think it is triggering the form submit when you are pressing Enter, the Ctrl modifier isn't doing anything.

There is no user integration at this very minute, so nothing we seem completed in the map

[joops75]

I've fixed the issue of the Ctrl key having no effect when pressing enter on my machine (Windows 7 64-bit, Firefox Quantum 60.0.1 64-bit). It involves adding in 'onkeydown' and 'onkeyup' event listeners. Not sure if this approach is overkill. Should I submit a pull request? Alternatively, the button text could be simply changed from "I've completed this challenge (Ctrl + Enter)" to "I've completed this challenge (Enter)"

[tchaffee]

@Bouncey @joops75 Any update on this?

[joops75]

@tchaffee Nothing from my end, I'm still awaiting instruction on my previously mentioned solutions.
@Bouncey Sorry, I should have tagged you in my last message.

[Bouncey]

I don't think changing the hot keys between challenges is a good idea in terms of UX.

As we are working with a form, we could add an onKeyDown prop to listen for Ctrl || Cmd + Enter which then calls this.handleSubmit ( this is from the top of my head, implementation would be different )

[joops75]

@Bouncey I've submitted a PR for this.

[Bouncey]

Closed via #181