Comments (5)
Not sure if this is the same issue, but there is a bug in the wheel zoom policy.
This line calls _zoom with three parameters (zoom, centerX, centerY):
https://github.com/freegroup/draw2d/blob/master/src/policy/canvas/WheelZoomPolicy.js#L127
But _zoom expects two parameters (zoom, centerPoint).
from draw2d.
I understand the first part of the ticket (width instead of Height)...but the second part is not clear to me.
Can you please explain it in more detail?
from draw2d.
Hi, it was quite a while ago, but as far as I can remember the problem in second part is that in setDimension we are calling this.setZoom with the first argument being zoomFactor of canvas, which after being passed to WheelZoomPolicy's zoom handler is checked for equality with itself in that condition and thus condition will always be true.
Here is a flow:
Line 683 in f228358
Line 623 in f228358
draw2d/src/policy/canvas/WheelZoomPolicy.js
Line 134 in f228358
draw2d/src/policy/canvas/WheelZoomPolicy.js
Line 149 in f228358
in the end zoom and canvas.zoomFactor is the same variable. Thus there is no actions from WheelZoomPolicy's zoom handler on changing dimensions and as far as I can remember the problem was that zoom is reset to 1:1 in the start of setDimension but because of that condition was not applied back in the end.
Unfortunately I don't remember how I thought to fix it, haven't worked with draw2d for a while.
from draw2d.
I got it. Try to fix it
from draw2d.
I'm trying to use WeelZoomPolicy but I have some problems.
- If I try to use
canvas.installEditPolicy(new draw2d.policy.canvas.WheelZoomPolicy({
onMouseWheel: function(){
// This is a <span>
$("#draw2d_canvas_zoom").text(canvas.getZoom());
}
}));
I get in console
WheelZoomPolicy.js:159 Uncaught TypeError: Cannot read property 'zoomFactor' of null
at Class._zoom (WheelZoomPolicy.js:159)
at step (WheelZoomPolicy.js:137)
at t.value (shifty.js:2)
at shifty.js:2
from draw2d.
Related Issues (20)
- extends function not set with jason reader HOT 1
- How to disable click to add vertex to a polygon HOT 6
- Using own svg as content HOT 1
- draw2d.org website shows camping electric calculator? HOT 1
- How to Use ManhattanConnectionRouter with explicit waypoints HOT 1
- npm audit report HOT 2
- Make implicit dependencies in lib/*.exec.js explicit. HOT 3
- How to develop a custom "input" shape? HOT 2
- Wrong link HOT 2
- Missing Documentation HOT 1
- where is the old documentation ? HOT 2
- Custom html shape
- Grid doesn't fill in after zooming
- Selecting multiple, move, then move one item causes crash
- Can't connect ports together from the same object
- The version of its xmldom dependency is deprecated
- Scrolling breaks draw2d
- Clicking on draw2d canvas doesn't take focus away from inputs
- Have problem with undo/redo
- Any plans for the next release? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from draw2d.