Comments (5)
@petervojtek spravil som Layes
znova bezstavovym funkcionalnym komponentom. Zbytocne si tam zaviedol stav a preniesol definicie zakladnych vrstiev z mapDefinitions.js
.
from freemap-v3-react.
Martin @zdila , podla mna tvoje zmeny sposobuju horsiu citatelnost kodu:
- toto je bez kontextu tazko zrozumitelne a v buducnosti nachylne na rozne chyby.
- namiesto tohto je podla mna prehladnejsie explicitne vymenovat string-y (ako casto sa za poslednych 5 rokov menili na freemap zakladne vrstvy?)
- mapDefinitions -- kym to pouziva iba jeden komponent, nevidim pointu mat tie definicie vo vlastnom subore -- len to zhorsuje citatelnost.
from freemap-v3-react.
absolutne si dovolim nesuhlasit s prvym bodom. spomen nejake chyby na ktore je to nachylne.
nachylne na chyby su stavove komponenty. sablona mapy definuje uz teraz {s}, {x}, {y}, {z} takze pridat jdnu naviac nevidim ako ziaden problem. naviac aj jej nazov vravi o com je.
k druhemu bodu - mozeme to dat do extra supboru s nasimi proptypes, ale opakovat stale tie site stringy mi nepride ako velmi dobra programatorska praktika
k poslednemu, tiez nechapem co tym mienis. nie preto sa delia moduly a funkcie do mensich, lebo sa pouzivaju na viacerych miestach, ale preto, lebo to zvysuje citatelnost. ale hlavne ze si v mapDefinitions nechal overlays - to ti tam uz nevadilo?
pozri si rozne ine projekty, tam je takato praktika bezna. nie pisat dlhe subory, ale delit ich do mensich celkov kde kazdy celok definuje presne domenu.
from freemap-v3-react.
absolutne si dovolim nesuhlasit s prvym bodom. spomen nejake chyby na ktore je to nachylne.
prepac, mas pravdu, na prvy pohlad som si myslel ze to hladas/replacujes na zaklade stringu 'jpg'/'png'.
ale hlavne ze si v mapDefinitions nechal overlays - to ti tam uz nevadilo?
mal som v plane to tiez odtial presunut do Layers :)
from freemap-v3-react.
V e42f9b9 som vyextrahoval "nase" proptypes do extra reusable suboru
from freemap-v3-react.
Related Issues (20)
- Lišta na úzkom telefóne
- Add option step back while editing HOT 1
- The slope of the drawn path
- Šírka čiary sa nedá prepísať
- Skryť možnosť "typ geometrie" pri bodoch.
- Hide map type in iframe
- Converting gpx to drawing duplicates segments HOT 1
- Uploading photos - tags dropdown does not collapse HOT 7
- Localize ReactTags
- Chyba pri otvorení mapy v JOSM HOT 1
- Track more events to Matomo
- Remove sending error to backend and only use Sentry
- Matomo: missing css on FF? HOT 3
- Find coordinates and elevation - request
- Dead link to Freemap o.z. on the Support us page
- Change keyboard shortcut HOT 1
- Show logged user first in photo filter
- Miniature of photo is loading infinitelly HOT 5
- prihlasovanie na iPhonoch nefunguje? HOT 4
- Nefunguje prihlasenie HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freemap-v3-react.