Neutral forces can see your stealthy ships on first bout already about freeorion

[geoffthemedio]

As far as I recall, the combat system doesn't distinguish between different ships on the same "team" for what is visible. For monsters/neutrals, that means that they all start being able to detect anything that any of them has sufficient detection strength to see.

Possibly the one turn differences could be related to stealth being a meter that's determined before movement, and the new location value not taking effect until the subsequent turn?

[Blue-Award]

In my repro, there's a fight with two planets. one has 60 detection, the other has 20 detection. When ships have 85 stealth, coming from starless system, they are seen. When they have 95 stealth, after they stayed around for a turn, or jumped from a system that had a star not giving penalty, they are not seen.

Similary drone factory, supposedly 10 vision, doesn't see the ships if they come in with 95 stealth, but sees them once they stay around its empty system, having 85 stealth.

It's almost as if neutrals had 90 detection strength

[Blue-Award]

Also generally, fighting other players, I am used to if there's mixed fleet with stealthy and not stealthy ships, the not stealthy ones are seen, but the stealthy are unseed on first bout. Like also happened in mp25 for example fight with 9 of my ships, 7 stealthy enough are mentioned as not detected until they launch their fighters,

[Blue-Award]

I think I found the issue, CombatInfo::GetMonsterDetection looks like monsters are getting detection strenght equal to MY detection (range), instead of monsters' detection. So when I am at empty system, I have 85 range, so that's the strength monsters get, which happens to coincide with me having 85 stealth then. Cause empty system is both bonus to range and malus to stealth. Should be able to prepare a PR fix myself