freerdp / freerdp

FreeRDP is a free remote desktop protocol library and clients

FreeRDP: A Remote Desktop Protocol Implementation

FreeRDP is a free implementation of the Remote Desktop Protocol (RDP), released under the Apache license. Enjoy the freedom of using your software wherever you want, the way you want it, in a world where interoperability can finally liberate your computing experience.

Code Quality Status

Resources

Project website: https://www.freerdp.com/
Issue tracker: https://github.com/FreeRDP/FreeRDP/issues
Sources: https://github.com/FreeRDP/FreeRDP/
Downloads: https://pub.freerdp.com/releases/
Wiki: https://github.com/FreeRDP/FreeRDP/wiki
API documentation: https://pub.freerdp.com/api/

Security policy: https://github.com/FreeRDP/FreeRDP/security/policy

Matrix room : #FreeRDP:matrix.org (main) XMPP channel: #FreeRDP#[email protected] (bridged) IRC channel : #freerdp @ irc.oftc.net (bridged) Mailing list: https://lists.sourceforge.net/lists/listinfo/freerdp-devel

Microsoft Open Specifications

Information regarding the Microsoft Open Specifications can be found at: https://www.microsoft.com/openspecifications/

A list of reference documentation is maintained here: https://github.com/FreeRDP/FreeRDP/wiki/Reference-Documentation

Compilation

Instructions on how to get started compiling FreeRDP can be found on the wiki: https://github.com/FreeRDP/FreeRDP/wiki/Compilation

freerdp's Issues

FreeRDP does not close if server is turned off

If I'm logged in the remote session and turn off the server, FreeRDP will no close and will issue a 100% CPU burst.

Make "HOME" directory configurable for certstore and registry

Currently certstore and registry use getenv("HOME") to get a writable location for data files. On Platforms where HOME is not correctly set in the environment this will cause both data stores to fail (i.e. in case HOME is not set certstore will SEGFAULT at line 71 in certstore.c).
The best solution would be to allow the UI front end to override the "home" directory in the settings and if present, this setting is used by all data store helpers instead of getenv(HOME).

Parallel Port Redirection

Migrate the parallel port redirection plugin to 1.0.

FreeRDP1.0 grabs window manager key combinations (Patch attached)

Patch: https://gist.github.com/1262109

freerdp.pc (pkg-config file) missing

freerdp does not install freerdp.pc (pkg-config file). Other packages (e.g. remmina) do not even try to build with freerdp.

X11 client freezes indefinitely if connection is lost

During a remote session, if the connection to the server gets lost (cable disconnected in my tests), X11 client will freeze indefinitely (or is there a timeout for that?).

Microsoft's client freezes as well, but it attempts to reconnect to the server in, say 30, seconds.

Delay when exiting a RemoteApp

Under curretn git, when I exit a RemoteApp, there is a often, but not always, a long pause before xfreerdp returns and it prints:

ERRINFO_RPC_INITIATED_DISCONNECT_BY_USER (0x0000000B):
The disconnection was initiated by an administrative tool on the server running in the user's session.
rdp_client_connect_demand_active failed
SSL_read: I/O error
SSL_read: I/O error
Failed to check FreeRDP file descriptor

on the terminal.

Serial Port Redirection

Migrate the serial port redirection plugin to 1.0.

Audin does not work

It is not creating the channel because this test fails: (dvcman.c (300): if (strcmp(listener->channel_name, ChannelName) == 0))
As you can see in the following debug, ChannelName=PNPDR, when it should be AUDIO_INPUT...

$ client/X11/xfreerdp -u *** -p *** --plugin drdynvc --data audin:alsa -- win7e
DBG_DVC drdynvc_process_connect (321): connecting
DBG_DVC dvcman_register_plugin (146): num_plugins 0
DBG_DVC audin_register_device_plugin (431): device registered.
DBG_DVC audin_plugin_initialize (391): 
DBG_DVC dvcman_create_listener (101): 0.AUDIO_INPUT.
DBG_DVC drdynvc_process_receive (290): Cmd=0x5
DBG_DVC drdynvc_process_capability_request (158): Sp=0 cbChId=0
DBG_DVC drdynvc_process_receive (290): Cmd=0x1
DBG_DVC drdynvc_process_create_request (208): ChannelId=0 ChannelName=PNPDR
DBG_DVC drdynvc_process_create_request (224): no listener
Failed to check xfreerdp file descriptor
DBG_DVC drdynvc_process_terminate (337): terminating
DBG_DVC audin_plugin_terminated (406): 
DBG_DVC audin_alsa_close (311): 

xfreerdp cursor support

Add support for cursors in xfreerdp

farm server redirection asks twice for the password

Hello

I updated from git revision f14145e.. to 162b33b.. and xfreerdp prompt is now asking twice for the password:

once when connecting to the main server and once when connecting to the farm sub-server I get redirected to.

It used to ask it only once when connecting to the main server and the information was somehow automatically transmitted to the farm sub-server.

All servers are 2008R2

I don't know if you need any further testing to pinpoint the exact commit that caused the change, just let me know :-)

Many thanks.

virtual channels should support compression

Compression breaks rdpdr; will likely cause segfault

loading plugin rdpdr
connected to <...>
svc_plugin_process_received: read error
Warning rdpdr_process_capability_request (162): Unknown capabilityType 11264
Warning rdpdr_process_capability_request (162): Unknown capabilityType 44235
Warning rdpdr_process_capability_request (162): Unknown capabilityType 4000
... many Warnings

edit: updated title

Fail to connect to windows XP

With my windows XP the negotiation go to RDP but it fail to connect because encryption is disabled (only work if i put --sec rdp on command line).

So I made a patch wich enable encryption with RDP https://bitbucket.org/grazy/freerdp/changeset/3246eac20c95 (bitbucket because i have a problem with my fork on github)

Please can you merge it. It will able people to connect easily to windows XP.

For Information I have a windows XP French.
I think that the exception in gcc_write_client_security_data
(https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp-core/gcc.c#L761) for french is not necessary anymore.

16-bit X displays are not usable

When the X11 display is set to 16-bit, the colors are all way off, as is the resolution. Things are a bit enlarged. It is quite unusable.

Video: mach64, 1440x900x16, Fedora 14
Server: 2008 R2 Standard

Port rdp extension code

warning during compilation in cliprdr_format.c

Here is a very minor patch :

diff --git a/channels/cliprdr/cliprdr_format.c b/channels/cliprdr/cliprdr_format.c
index 6cce758..8b2d00f 100644
--- a/channels/cliprdr/cliprdr_format.c
+++ b/channels/cliprdr/cliprdr_format.c
@@ -87,7 +87,7 @@ void cliprdr_process_format_list(cliprdrPlugin* cliprdr, STREAM* data_in, uint32
cb_event->formats = (uint32*)xmalloc(sizeof(uint32) * num_formats);
cb_event->num_formats = 0;
if (num_formats * 36 != dataLen)

•           DEBUG_WARN("dataLen %d not devided by 36!");
  

•           DEBUG_WARN("dataLen %d not divided by 36!", dataLen);
  for (i = 0; i < num_formats; i++)
  {
          stream_read_uint32(data_in, format);
  

(sorry, I still have to learn how to use git and github properly)

client authenticate callback

Add an interactive password prompt when connecting without passing enough of the credentials at command line.

USB support

I noticed http://www.freerdp.com/wiki/doku.php?id=usb_redirection and wonder if there is other activity on this issue that I have not found? Please consider it for future releases!

Segfault on Startup for xmonad (and probably other tiling window managers)

xmonad does not define the _NET_CURRENT_DESKTOP atom (I'm not sure why, but http://code.google.com/p/xmonad/issues/detail?id=381 seems to suggest that some expected atoms don't make sense for tiling window managers). This results in a segfault in xf_GetWindowProperty. This is both a bug report (freerdp should fail gracefully, not segfault) and a feature request (support tiling window managers in freerdp).

Smartcard Redirection

Migrate the smartcard redirection plugin to 1.0.

Segfault with cliprdr + rail plugins

Trying to get clipboard support with the rail plugins.

Command:
/home/vivitron/dev/FreeRDP/client/X11/xfreerdp -u Administrator --plugin /home/vivitron/dev/FreeRDP/channels/cliprdr/cliprdr.so --app --plugin /home/vivitron/dev/FreeRDP/channels/rail/rail.so --data "||excel" -- 192.168.56.101

Output:
loading plugin /home/vivitron/dev/FreeRDP/channels/cliprdr/cliprdr.so
loading plugin /home/vivitron/dev/FreeRDP/channels/rail/rail.so
connected to 192.168.56.101:3389
Password:
Segmentation fault

Works fine if I exclude the cliprdr plugin...

RemoteApp does not show window logon banner

I have built the current FreeRDP on Debian. I can connect to the full desktop my Windows 2008 RDS server using any of the three security protocols (rdp, tls, nla). But when I attempt the RemoteApp feature, I never see a window to click OK to the Windows logon banner. This is the banner set via group policy called "Message text for user attempting to log on".

My suspicion is that the --app parameter or the rail plugin is checking for the application on the other end before showing the window, but I need to see the full window in order to click OK. I'm willing to provide more information to help this feature succeed. I think RemoteApp paves the way for more non-Windows clients in the workplace.

Multimedia Redirection

Migrate the multimedia redirection plugin (drdynvc/tsmf) along with its subsystems (alsa, pulse, ffmpeg) to 1.0.

can not compile under ubuntu

I tried to compile the dc224b1 version, and got the following error:

[ 80%] Building C object channels/drdynvc/tsmf/ffmpeg/CMakeFiles/tsmf_ffmpeg.dir/tsmf_ffmpeg.c.o
/home/will/Work/freerdp/freerdp_dev/channels/drdynvc/tsmf/ffmpeg/tsmf_ffmpeg.c: In function ‘tsmf_ffmpeg_init_audio_stream’:
/home/will/Work/freerdp/freerdp_dev/channels/drdynvc/tsmf/ffmpeg/tsmf_ffmpeg.c:94: error: ‘FF_MM_MMX2’ undeclared (first use in this function)
/home/will/Work/freerdp/freerdp_dev/channels/drdynvc/tsmf/ffmpeg/tsmf_ffmpeg.c:94: error: (Each undeclared identifier is reported only once
/home/will/Work/freerdp/freerdp_dev/channels/drdynvc/tsmf/ffmpeg/tsmf_ffmpeg.c:94: error: for each function it appears in.)
At top level:
cc1: warning: unrecognized command line option "-Wno-unused-but-set-variable"
make[2]: *** [channels/drdynvc/tsmf/ffmpeg/CMakeFiles/tsmf_ffmpeg.dir/tsmf_ffmpeg.c.o] Error 1
make[1]: *** [channels/drdynvc/tsmf/ffmpeg/CMakeFiles/tsmf_ffmpeg.dir/all] Error 2
make: *** [all] Error 2

before compiling, I typed "cmake ." and got the following information:

will@will-ubuntu:~/Work/freerdp/freerdp_dev$ cmake .
-- The C compiler identification is GNU
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- FreeRDP GIT
-- Performing Test Wno-unused-but-set-variable
-- Performing Test Wno-unused-but-set-variable - Success
-- Looking for include files HAVE_SYS_PARAM_H
-- Looking for include files HAVE_SYS_PARAM_H - found
-- Looking for include files HAVE_SYS_SOCKET_H
-- Looking for include files HAVE_SYS_SOCKET_H - found
-- Looking for include files HAVE_NETDB_H
-- Looking for include files HAVE_NETDB_H - found
-- Looking for include files HAVE_FCNTL_H
-- Looking for include files HAVE_FCNTL_H - found
-- Looking for include files HAVE_UNISTD_H
-- Looking for include files HAVE_UNISTD_H - found
-- Found OpenSSL: /usr/lib/libssl.so;/usr/lib/libcrypto.so
-- Found ZLIB: /usr/lib/libz.so
-- Finding suggested package ALSA.
-- Disable this using "-DWITH_ALSA=OFF".
-- Found ALSA: /usr/lib/libasound.so
-- Skipping optional package PulseAudio.
-- Enable this using "-DWITH_PULSEAUDIO=ON".
-- Finding suggested package Cups.
-- Disable this using "-DWITH_CUPS=OFF".
-- Looking for ippDeleteAttribute in cups
-- Looking for ippDeleteAttribute in cups - found
-- Found Cups: /usr/lib/libcups.so
-- Finding suggested package FFmpeg.
-- Disable this using "-DWITH_FFMPEG=OFF".
-- checking for module 'libavcodec'
-- found libavcodec, version 52.20.1
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
-- Skipping optional package CUnit.
-- Enable this using "-DWITH_CUNIT=ON".
-- Looking for include files CMAKE_HAVE_PTHREAD_H
-- Looking for include files CMAKE_HAVE_PTHREAD_H - found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Finding suggested package XKBFile.
-- Disable this using "-DWITH_XKBFILE=OFF".
-- Found XKBFILE: /usr/lib/libxkbfile.so
-- Finding suggested package X11.
-- Disable this using "-DWITH_X11=OFF".
-- Found X11: /usr/lib/libX11.so
CMake Warning at client/X11/CMakeLists.txt:54 (message):
WITH_MANPAGES was set, but xmlto was not found. man-pages will not be
installed

-- Finding suggested package Xinerama.
-- Disable this using "-DWITH_XINERAMA=OFF".
-- Found XINERAMA: /usr/lib/libXinerama.so
-- Finding suggested package Xext.
-- Disable this using "-DWITH_XEXT=OFF".
-- Found XEXT: /usr/lib/libXext.so
-- Finding suggested package Xcursor.
-- Disable this using "-DWITH_XCURSOR=OFF".
-- Found Xcursor: /usr/lib/libXcursor.so
-- Finding suggested package Xv.
-- Disable this using "-DWITH_XV=OFF".
-- Found XV: /usr/lib/libXv.so
-- Skipping optional package DirectFB.
-- Enable this using "-DWITH_DIRECTFB=ON".
-- Finding suggested package X11.
-- Disable this using "-DWITH_X11=OFF".
-- Finding suggested package Xext.
-- Disable this using "-DWITH_XEXT=OFF".
-- Configuring done
-- Generating done
-- Build files have been written to: /home/will/Work/freerdp/freerdp_dev

Thank anyone who can solve this problem.

Plug and Play Device Redirection

Migrate the drdynvc/pnpdr plugin to 1.0.

compose key support

In FreeRDP/FreeRDP-old#43 we had a discussion on supporting the compose key in freerdp with some cool ideas ... has any work been done in this direction?

glyph drawing orders

Add support for glyph caching along with associated drawing orders. This is currently disabled, so the server sends text as bitmap updates, which is much slower.

Segfault in xf_tsmf_init under OS X

(gdb) where
#0 0x00000001005062bb in _X11TransWritev ()
#1 0x00000001004feaef in _XSend ()
#2 0x00000001004f3c56 in XQueryExtension ()
#3 0x00000001004e9281 in XInitExtension ()
#4 0x00000001004d0f1e in XextAddDisplay ()
#5 0x000000010003d67b in XvQueryExtension ()
#6 0x000000010000a605 in xf_tsmf_init (xfi=0x101000000, xv_port=0) at /Users/danielcolascione/software/FreeRDP/client/X11/xf_tsmf.c:86
#7 0x000000010000fdb5 in xf_post_connect (instance=0x100700630) at /Users/danielcolascione/software/FreeRDP/client/X11/xfreerdp.c:468
#8 0x000000010006041f in freerdp_connect (instance=0x100700630) at /Users/danielcolascione/software/FreeRDP/libfreerdp-core/freerdp.c:49
#9 0x0000000100010395 in xfreerdp_run (instance=0x100700630) at /Users/danielcolascione/software/FreeRDP/client/X11/xfreerdp.c:645
#10 0x00000001000106a0 in thread_func (param=0x100701120) at /Users/danielcolascione/software/FreeRDP/client/X11/xfreerdp.c:735
#11 0x00007fff85cbafd6 in _pthread_start ()
#12 0x00007fff85cbae89 in thread_start ()

(gdb)

cert thumbprint store function is not called

https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp-core/tls.c#L272
cert_data_print(certstore);

That line was missing.

bitmap caching orders

Add support for the bitmap cache, along with associated drawing orders that make use of a cached bitmap, such as memblt and mem3blt. Support for persistent bitmap caching is also a plus that we should have.

RemoteApp not working with XP-Mode

When running xfreerdp from git to a XP-Mode running in Virtual box on Ubuntu Natty I only get the following message but no windows with the app:

loading plugin channels/rail/rail.so
connected to 192.168.56.101:3389
incorrect offset, type:0x14 actual:12 expected:8
incorrect offset, type:0x0E actual:8 expected:4
incorrect offset, type:0x14 actual:12 expected:8
incorrect offset, type:0x0E actual:8 expected:4

Running a full session gives me the same messages but does show a desktop.

Please advice.

rdpsnd/pulseaudio plugin does not work

Enabled debug output, it shows bad stream state (PA_ERR_INVALID)

Load plugin rdpsnd
DBG_SVC rdpsnd_process_connect (495): connecting
DBG_SVC rdpsnd_pulse_context_state_callback (66): state 1
DBG_SVC rdpsnd_pulse_context_state_callback (66): state 2
DBG_SVC rdpsnd_pulse_context_state_callback (66): state 3
DBG_SVC rdpsnd_pulse_context_state_callback (55): PA_CONTEXT_READY
DBG_SVC rdpsnd_pulse_connect (106): connected
DBG_SVC rdpsnd_process_receive (402): msgType 7 BodySize 696
DBG_SVC rdpsnd_process_message_formats (181): wNumberOfFormats 22 wVersion 6
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=1 nChannels=2 nSamplesPerSec=44100 nBlockAlign=4 wBitsPerSample=16
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=2 nChannels=2 nSamplesPerSec=44100 nBlockAlign=2048 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=17 nChannels=2 nSamplesPerSec=44100 nBlockAlign=2048 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=6 nChannels=2 nSamplesPerSec=22050 nBlockAlign=2 wBitsPerSample=8
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=2 nChannels=2 nSamplesPerSec=22050 nBlockAlign=1024 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=17 nChannels=2 nSamplesPerSec=22050 nBlockAlign=1024 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=2 nChannels=1 nSamplesPerSec=44100 nBlockAlign=1024 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=17 nChannels=1 nSamplesPerSec=44100 nBlockAlign=1024 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=2 nChannels=2 nSamplesPerSec=11025 nBlockAlign=512 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=17 nChannels=2 nSamplesPerSec=11025 nBlockAlign=512 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=2 nChannels=1 nSamplesPerSec=22050 nBlockAlign=512 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=17 nChannels=1 nSamplesPerSec=22050 nBlockAlign=512 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=49 nChannels=1 nSamplesPerSec=44100 nBlockAlign=65 wBitsPerSample=0
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=2 nChannels=2 nSamplesPerSec=8000 nBlockAlign=512 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=17 nChannels=2 nSamplesPerSec=8000 nBlockAlign=512 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=2 nChannels=1 nSamplesPerSec=11025 nBlockAlign=256 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=17 nChannels=1 nSamplesPerSec=11025 nBlockAlign=256 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=49 nChannels=1 nSamplesPerSec=22050 nBlockAlign=65 wBitsPerSample=0
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=2 nChannels=1 nSamplesPerSec=8000 nBlockAlign=256 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=17 nChannels=1 nSamplesPerSec=8000 nBlockAlign=256 wBitsPerSample=4
DBG_SVC rdpsnd_process_message_formats (231): format supported.
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=49 nChannels=1 nSamplesPerSec=11025 nBlockAlign=65 wBitsPerSample=0
DBG_SVC rdpsnd_process_message_formats (221): wFormatTag=49 nChannels=1 nSamplesPerSec=8000 nBlockAlign=65 wBitsPerSample=0
DBG_SVC rdpsnd_process_receive (402): msgType 6 BodySize 1020
DBG_SVC rdpsnd_process_receive (402): msgType 2 BodySize 4104
DBG_SVC rdpsnd_process_message_wave_info (310): waveDataSize 4096 wFormatNo 4
DBG_SVC rdpsnd_pulse_stream_state_callback (149): PA_STREAM_FAILED/PA_STREAM_FAILED state 3

segfault with --no-nla enabled

With --no-nla parameter, freerdp segfaults. Does not happen with any prameter-combination (for example if a user is also specified).

Way to reproduce: xfreerdp --no-nla $server

Windows Port

FreeRDP 1.0 currently compiles on Windows, but wfreerdp has been barely touched. We would need to have a complete windows port at some point to match what we had in 0.x. I am not sure if we should delay 1.0 for wfreerdp though.

dfreerdp fails to work in fullscreen mode

When trying to execute a DirectFB session using either the X11 or fbdev system, the "dfreerdp -f" option always fails if the screen resolution in then ~/.directfbrc is equal to the native screen resolution set in X or Framebuffer mode.

Caught signal 11 (at 0x7f4338f66000, invalid permissions) <--

tried to execute with gdb to no avail!!

Audio Input Redirection (audin)

Migrating the drdynvc/audin virtual channel plugin to 1.0

RemoteFX in FreeRDP 1.0 does not work

I`ve tried in many circumstances under debian squeeze using FreeRDP 1.0 (compiled from github) with ffmpeg support built-in.

xfreerdp -u user -p pass -d domain -f --rfx

RemoteFX is always disabled on the RD Session Host session.

This is confirmed to work from a Windows 7 SP1 client ..

Full screen mode is not properly working

When passing the -f option, the screen gets black and I can only see the cursor. Ctrl + Alt + Enter gives my operating system back, though I can't enter the connection again.

Support -a 8

fix 8 bit color support

farm server redirection segfault at session closing

Hello

using xfreerdp (rev. 162b33b..) to connect to a farm server, when I close the session, I experience a segfault apparently related to redirection :

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff45d3700 (LWP 31136)]
*__GI___libc_free (mem=0x2e003300390031) at malloc.c:3709
3709 malloc.c: Aucun fichier ou dossier de ce type.
in malloc.c
(gdb) bt
#0 *__GI___libc_free (mem=0x2e003300390031) at malloc.c:3709
#1 0x00007ffff692207f in xfree (ptr=0x2e003300390031) at FreeRDP-1.0/libfreerdp-utils/memory.c:95
#2 0x00007ffff692485b in freerdp_string_free (string=0x696058)

at /home/alexis/tmp/FreeRDP-1.0/libfreerdp-utils/string.c:35

#3 0x00007ffff739a2a6 in redirection_free (redirection=0x637250)

at FreeRDP-1.0/libfreerdp-core/redirection.c:204

#4 0x00007ffff739bdc3 in rdp_free (rdp=0x6254d0) at FreeRDP-1.0/libfreerdp-core/rdp.c:843
#5 0x00007ffff7391943 in freerdp_free (freerdp=0x625460) at FreeRDP-1.0/libfreerdp-core/freerdp.c:173
#6 0x0000000000415072 in xfreerdp_run (instance=0x625460) at FreeRDP-1.0/client/X11/xfreerdp.c:919
#7 0x00000000004150b0 in thread_func (param=0x647d40) at FreeRDP-1.0/client/X11/xfreerdp.c:930
#8 0x00007ffff53939ca in start_thread (arg=) at pthread_create.c:300
#9 0x00007ffff50f070d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#10 0x0000000000000000 in ?? ()

microsoft word 2003 cannot save files to redirected directory

I've been using a recent git (1 month old) git build of xfreerdp.

I've noticed that while exchanging files with redirected directory works fine, ms word 2003 has problems saving documents to it, claiming that there is not enough space or memory to do this operation.

Saving text files from e.g. notepad works fine.

It seems that some kind of file access that ms word needs is not forwarded properly. looking at contents of directory i can see that word makes a 0 byte file, fillis it up to 4096 bytes and then the error message displays.

when using rdesktop, everything works correctly.

steps to reproduce

• run a rdp session with redirected directory
• start word 2003
• create an arbitrary document
• attempt to save to shared directory - it fails
• retry whole operation with rdesktop - it works fine

cmake and config.h not found

Hi

when using cmake, I usually build everything in a separate directory :

mkdir Build
cd Build
cmake path/to/main/cmakelists.txt

since config.h is created using

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config.h.in ${CMAKE_CURRENT_BINARY_DIR}/config.h)

CMAKE_CURRENT_BINARY_DIR should be added to the include path in the main CMakeLists.txt :

include_directories(${CMAKE_CURRENT_BINARY_DIR})

Otherwise I get this error :

FreeRDP-1.0/libfreerdp-utils/svc_plugin.c:21:20: error: config.h: File not found

Another solution would be to put config.h in include or at the root

Also, HAVE_CONFIG_H is always false

Missing text and segfault

With current git using remoteapp to 2008R2, the program starts ok, but various buttons that should have "ghosted" text are blank and xfreerdp segfaults as soon as I try to actually do anything. I get the same behavior with --gdi software or hw.

When using a complete desktop the font problem still occurs, but the segfault does not.

handle smartcard reader reconnection

For reference, FreeRDP/FreeRDP-old#19

smartcard inserts & removals should work, but reader removal & reconnection isnt handled properly.

Window movement causes odd behavior

I start an app in remoteApp mode, then move the window. The window appears to move just fine, but something gets confused. Just clicking in the app window after the move causes the entire windows to jump to a new location.

Current git talking to 2008 R2 server.

audio input segfault

migrating from FreeRDP/FreeRDP-old#26

There is a race with the audin_alsa_thread_func, workaround here (not recommended fix).

https://github.com/atong-tcs/FreeRDP/commit/8fb201a2145dc08ab95ed5464afafc1a3ad26249

FreeRDP crashes after pressing Alt+F4 in RemoteApp mode

Sorry, I haven't found any bugtracker, so I write it here. After pressing Alt+F4 on one of the opened windows or closing it from the task bar FreeRDP crashes with this message:

XIO: fatal IO error 11 (Resource temporarily unavailable) on X server ":0"
after 413 requests (413 known processed) with 0 events remaining.

It looks like that you don't handle WM_DELETE_WINDOW properly. It's really painful when you are trying to close a window seing a semi-transparent rectangle instead of it...

Exit codes

xf_GetWorkArea doesn't check return value of xf_GetCurrentDesktop

libfreerdp-gdi ScrBlt

When multiple ScrBlt messages are fired by the server in a very fast sequence, libfreerdp-gdi starts rendering graphics improperly. This bug does not seem to affect the X11-specific GDI implementation. This bug was observed with the Windows 8 Developer Preview in RemoteFX mode, where the only non-RemoteFX message received was ScrBlt.