GithubHelp home page GithubHelp logo

Comments (7)

frenic avatar frenic commented on August 16, 2024 1

Thank you for raising this. My best guess would be to add them to mdn/data rather than mdn/browser-compat-data because it's an old spec. I created an issue to see what they have to say.

from csstype.

basicdays avatar basicdays commented on August 16, 2024

Found a couple more:

  • -ms-grid-column-align
  • -ms-grid-row-align

from csstype.

basicdays avatar basicdays commented on August 16, 2024

Using the follow definition file as a temporary workaround.

export type MSGridRowAlignProperty = 'start' | 'end' | 'center' | 'stretch';
export type MSGridColumnAlignProperty = 'start' | 'end' | 'center' | 'stretch';

declare module 'csstype' {
	interface Properties {
		msGridRow?: number;
		'-ms-grid-row'?: number;

		msGridRowSpan?: number;
		'-ms-grid-row-span'?: number;

		msGridRowAlign?: MSGridRowAlignProperty;
		'-ms-grid-row-align'?: MSGridRowAlignProperty;

		msGridColumn?: number;
		'-ms-grid-column'?: number;

		msGridColumnSpan?: number;
		'-ms-grid-column-span'?: number;

		msGridColumnAlign?: MSGridColumnAlignProperty;
		'-ms-grid-column-align'?: MSGridColumnAlignProperty;
	}
}

from csstype.

pompomon avatar pompomon commented on August 16, 2024

I've found that those properties were recently added to mdn/browser-compat-data, please @frenic would that be OK from your point of view?

from csstype.

frenic avatar frenic commented on August 16, 2024

Yes, I noticed. But these changes will be ignored as they were added as separate properties and no syntaxes are specified at https://github.com/mdn/data/ for these properties. An alternative could be to add them as patches.

from csstype.

pompomon avatar pompomon commented on August 16, 2024

I see, thanks for the clarification!
Please could you elaborate on adding them as patches?
I'll gladly prepare a PR with the changes, but I'd need to understand what you are suggesting :)

from csstype.

frenic avatar frenic commented on August 16, 2024

Related mdn/data#425

from csstype.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.