GithubHelp home page GithubHelp logo

Comments (3)

bvenn avatar bvenn commented on September 26, 2024

This is the problem:

min nan 1  //results in nan
max nan 1  //results in nan

1. < nan //false
1. > nan //false

I think the best option is to return a empty Interval if the collection contains a nan. This leads to an additional check for each element if it is nan, but I think this is a necessary step.

from fsharp.stats.

bvenn avatar bvenn commented on September 26, 2024

After reevaluation we came to the conclusion that a nan in a collection should throw an exception, so the user has full control and notices that something is odd in the data.

The function should be updated to allow overloads with arguments that define what happens to nan values.

from fsharp.stats.

bvenn avatar bvenn commented on September 26, 2024
Intervals.ofSeqBy snd (List.indexed [5;5;5;5])

results in ClosedInterval ((0, 5), (0, 5)). While not wrong by default, it would be beneficial if the Intergal maximum is the last occurrence within the collection. It can by fixed by modification of

let mmax,mmaxV = if current > maximum then current,e.Current else maximum,maximumV
to

let mmax,mmaxV = if current >= maximum then current,e.Current else maximum,maximumV

from fsharp.stats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.