Comments (3)
Thanks for reporting!:rocket:
I've traced down the issue to the following two lines:
The Array.rev
must be removed at:
FSharp.Stats/src/FSharp.Stats/Signal/Padding.fs
Lines 140 to 144 in 3d6a220
The last point has to be integrated here:
FSharp.Stats/src/FSharp.Stats/Signal/Padding.fs
Lines 164 to 167 in 3d6a220
After these modifications the result looks as follows:
//#r "nuget:FSharp.Stats"
#r @"C:\Users\bvenn\source\repos\FSharp.Stats\src\FSharp.Stats\bin\Release\netstandard2.0\FSharp.Stats.dll"
#r "nuget:Expecto"
#r "nuget: Plotly.NET"
open Plotly.NET
open System
open FSharp.Stats.Signal
open Expecto
let dataLength = 20
let padding = 10
let data =
Array.init dataLength (
fun i ->
(3.0 + float i, 7.0 - float i)
)
let expectLeadIn = Array.init padding (fun i -> (3.0 - float (padding-i), 0.0))
let expectLeadOut = Array.init padding (fun i -> (3.0 + float (dataLength + i), 0.0))
let expectedPadded = Array.concat [expectLeadIn; data; expectLeadOut]
let padded =
Padding.pad data 1.0 Double.PositiveInfinity (-) (+) padding Padding.BorderPaddingMethod.Zero Padding.InternalPaddingMethod.NaN Padding.HugeGapPaddingMethod.NaN
let indices = Array.init padded.Length (fun x -> string x)
[
Chart.Point(data,Name="raw data") |> Chart.withMarkerStyle (Size=10)
Chart.Point(expectedPadded,Name="expected") |> Chart.withMarkerStyle (Size=8)
Chart.Point(padded,Name="actual",MultiText=indices,TextPosition=StyleParam.TextPosition.TopRight) |> Chart.withMarkerStyle (Size=6)
]
|> Chart.combine
|> Chart.show
@marklam, if it is ok for you I would integrate your tests into the test project. Of course you can add them yourself and file a PR if you want to.
from fsharp.stats.
@bvenn I'm more than happy for you to integrate those tests. Thanks for responding so quickly!
from fsharp.stats.
closed by 153d95e
from fsharp.stats.
Related Issues (20)
- Minkowski distance HOT 4
- Documentation for Savitzky Golay filter
- t-Distributed Stochastic Neighbour Embedding (tSNE)
- Decision trees and random forest
- kNN classification HOT 1
- Documentation request for X² test
- [Feature Request] Surface fitting for simple data, and example that shows the surface in plotly HOT 5
- [Feature Request] NaN safety, we probably need something more than doc strings. HOT 2
- [Feature Request] review / remove [<AutoOpen>] on modules that overlay FSharp.Core collection types. HOT 2
- [Feature Request]addition of Normalized Mutual Information
- [BUG] Incorrect Behavior in FSharp.Stats.SpecializedGenericImpl.setColM for Non-Square Matrices
- [Feature Request] QR Matrix Decomposition using Gram-Schmidt HOT 2
- [Feature Request] weighted KNN imputation
- `JaggedCollection.transpose` results in wrong result when applied to rows of varying length
- [BUG] HierarchicalClustering cannot digest data of generic type anymore
- [BUG] Interval.isIntersection false positive on one-sided open intervals HOT 1
- [Feature Request] Support intersect on mixed interval types
- [BUG] Seq.weightedMean returns a function
- [BUG] Seq.stats returns wrong seq length (N)
- [Feature Request] Rename round operator HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fsharp.stats.