GithubHelp home page GithubHelp logo

A few comments about org-pretty-table HOT 6 CLOSED

tecosaur avatar tecosaur commented on June 27, 2024
A few comments

from org-pretty-table.

Comments (6)

Yevgnen avatar Yevgnen commented on June 27, 2024 1

The + does not work with GNU Emacs 27.1 (build 1, x86_64-apple-darwin20.1.0, Carbon Version 164 AppKit 2022.1) of 2020-11-15 and org 9.4/9.5-dev.

Screen Shot 2020-11-24 at 8 40 04 AM

from org-pretty-table.

Fuco1 avatar Fuco1 commented on June 27, 2024

The code for the + is already there, probably just doesn't work anymore :D Although I don't think org table syntax changed at all. Weird.

         ((equal "+" match)
          (cond
           ((and (eq (following-char) ?-)
                 (save-excursion
                   (backward-char 1)
                   (eq (preceding-char) ?-))
                 (save-excursion
                   (backward-char 1)
                   (previous-line)
                   (eq (following-char) ?|))
                 (save-excursion
                   (backward-char 1)
                   (next-line)
                   (eq (following-char) ?|)))
            (put-text-property (match-beginning 0) (match-end 0) 'display "")
            t)

The hyphen fix should be quite simple, we need to find the table, then get its limits (org-table-begin and org-table-end) and then use narrow-to-region to limit the scope of replacement.

I don't think I'll work on this in the future, I think I did it basically as a demo for someone who was interested in text properties and stuff.

But who knows, I'm doing a lot of presentations with https://github.com/takaxp/org-tree-slide lately so pretty tables might come handy some day. But no promises.

from org-pretty-table.

tecosaur avatar tecosaur commented on June 27, 2024

Thanks for getting back to me, and outlining the fix :)
I'll be overjoyed if I see this in the future.
Unfortunately, I'm lisp-illiterate — so I'll just hope for now.

from org-pretty-table.

daemianmack avatar daemianmack commented on June 27, 2024

I'm intermittently experiencing the same issue with the + character.

For what it's worth, disabling the mode and re-enabling org-pretty-table mode seems to fix the issue.

(GNU Emacs 28.0.50, stock org-mode.)

from org-pretty-table.

Fuco1 avatar Fuco1 commented on June 27, 2024

I've pushed some code to fix the + and other issues. If this resurfaces please let me know 🙏

from org-pretty-table.

Fuco1 avatar Fuco1 commented on June 27, 2024

It changes hyphens - for the entire buffer, not just tables

I also fixed this

from org-pretty-table.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.