Comments (11)
Good call. I need to revisit the already-passing side of the test suite and see why it's not catching things like this. It should be.
from clojure-koans.
I was looking at this a couple of months back and if I read the code right, each meditation fails if any of the tests within it fail. So, ensure-failing-without-answers just tests that each koan has at least one failing test. I wanted to experiment with a testing macro that changed the meditations in some way (maybe negating each test result and updating the answer sheet to expect the negated meditations to pass) so that it could make sure every test failed, but I haven't made the time to play with it.
from clojure-koans.
Skim - thanks again for the report.
Caleb - thanks for the macro-replacement idea. That's done now. I verified the new hotness catches this issue. It's a bit messy for now, but does the trick just fine.
from clojure-koans.
Again, this is still happening in the zip download. Perhaps I should just fork and have fun? :)
from clojure-koans.
Thanks for the heads-up. I uploaded the latest code as a zip file: https://github.com/downloads/functional-koans/clojure-koans/clojure-koans-2011-09-22.zip. The previously latest version was from August 1 (before this fix).
I need to figure out a way to automate this - would love suggestions on how if you have any.
from clojure-koans.
As a lowly Java dev, the only automation I know for this is Ant. Would be happy to have a look into if you let me know the steps you require for creating and making the .zip available.
from clojure-koans.
Yeah, by "automate" I mean have this jar built & uploaded when I commit to the github repo. After sleeping on it overnight, it seems easy enough to build the shell script I use for this into the repo itself. Thanks again for the report.
from clojure-koans.
My after sleeping on it is, "Shouldn't Lein be able to do that?" :)
from clojure-koans.
Lein absolutely could do that. I'm thinking of a script/deploy_koans.sh that does:
git push origin master
zip # [bunch of options redacted]
echo "Hey Colin, don't be a dummy - upload the zipfile!"
...since github's uploader is based on flash and not so API-friendly. Kind of low-tech, but this'll fix the immediate issue. I'm sure something clever exists for this, will try to take a look this afternoon.
from clojure-koans.
A) I'm conscious of how off topic we are on this issue, but don't
think what we are discussing is worthy of its own issue?
B) I would almost never suggest this since the zip file is an artifact
of the repository, but maybe the simple answer is to version the zip
file, then it's a simple matter of pushing the changes???
from clojure-koans.
Right, I'd rather not add the zip file (or even the jars in the lib directory) to the repo. I think adding a release process is the right move - that's the way most projects run, after all :)
from clojure-koans.
Related Issues (20)
- 13_creating_functions.clj (has a bug?) HOT 1
- Strict description of the rules HOT 2
- Problem with 15-destructuring.clj HOT 1
- 15_destructuring bug? HOT 3
- Can I translate koans? HOT 2
- Provide a way to run other 'sets' of koans HOT 2
- 24-macros / infix-better HOT 1
- 1.10 error messages break the koans HOT 3
- Not compatible with Clojure > 1.8 HOT 1
- Idea: hook this up as a jupyter notebook?
- Repl namespace issue HOT 1
- Koans for testing, Koans for agents HOT 2
- koans 19 datatypes, last meditation solution HOT 1
- Collection equality koan is confusing HOT 1
- 14 Recursion - is-even? HOT 1
- :refer :all HOT 4
- 24-macros contains two tests which can be made to pass with the same modification
- Unable to resolve symbol: hello in this context HOT 2
- confusion regarding "you can use a list as a stack to get the first element" koan. HOT 1
- the answer remains "AT&T Park".
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clojure-koans.