GithubHelp home page GithubHelp logo

Comments (9)

chadrien avatar chadrien commented on September 21, 2024 1

@jevakallio I will try to write such a shell script and open a PR if it goes well.

from pepperoni-app-kit.

VashMar avatar VashMar commented on September 21, 2024

Ended up just renaming manually, would be nice if there was an easier way though.

Edit: Renaming for the Podfiles is still quite painful, I'm still curious, is there a better way?

from pepperoni-app-kit.

jevakallio avatar jevakallio commented on September 21, 2024

Oh yes, documenting this is on our todo-list! The app is currently called "Kindling" (the original codename for the project), we will need to rename it anyway.

The way to go about this will probably be something like running the following in the root directory of your project:

sed -i 's/Kindling/YourAppName/g' *

(Above not tested)

from pepperoni-app-kit.

chadrien avatar chadrien commented on September 21, 2024

@jevakallio will it work in the cases of com.kindling in android build configuration?

Tested and (for now) working:

  • change the name in package.json
  • run react-native upgrade
    • on file conflict, press d to get the diff and locate the name changes (it will be from Kindling to YourAppName or from kindling to yourappname mostly)
    • once you located the name changes, apply them manually and say no to the upgrader so you don't lose additional stuff brought by Pepperoni
  • run (cd ios; rm -rf Kindling Kindling.xcodeproj Kindling.xcworkspace KindlingTests) (new xcode files should have been generated for your new app name)
  • edit YourAppName.xcodeproj/project.pbxproj and look for OTHER_LDFLAGS (there should have 2 occurrences). Change its value to $(inherited) (in my case it was from -ObjC or something)
  • run (cd ios; pod install)
  • change Kindling to YourAppName in index.ios.js and index.android.js

And you should be good to go. It's not easy, but it's not that hard either if you have the right todo list.

from pepperoni-app-kit.

jevakallio avatar jevakallio commented on September 21, 2024

@chadrien thanks for the instructions! I'll have to read those through and test for iOS and Android. Ideally we will need a solution that doesn't require running reacf native upgrade, as we will soon have a need for customisation in project files.

I think a shell script or a small cli tool bundled with the Pepperoni repo might be a way to go. This is something we will probably need eventually anyway for helping users bring in latest changes from the template to their projects.

from pepperoni-app-kit.

jevakallio avatar jevakallio commented on September 21, 2024

Furthermore we should rename the Kindling directory to something app-independent, so it doesn't need to be renamed by developers.

from pepperoni-app-kit.

jevakallio avatar jevakallio commented on September 21, 2024

@chadrien sweet!

from pepperoni-app-kit.

chadrien avatar chadrien commented on September 21, 2024

@jevakallio OK I think I'am on something working (run-ios and run-android both start the app and it seems to be functional).

Before opening a PR, could you tell me in which dir you'd like the script file to be, and what would be its name?

from pepperoni-app-kit.

jevakallio avatar jevakallio commented on September 21, 2024

@chadrien I think the file could be something like /support/rename.sh, or .js depending on what you wrote it in.

As a part of the PR, could you also do a rename from Kindling to PepperoniAppTemplate, and the same for the lowercase Android strings? That would be clearer and more guaranteed to be unique.

from pepperoni-app-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.