Zeitwerk, omniauth and multiple DBs (connects_to) about zeitwerk

[fxn]

OK, that is not good because middleware is not reloaded. In Rails 7 you won't be able to configure the provider (precisely, to avoid these situations). You should tell the autoloader to ignore lib/omni_auth:

Rails.autoloaders.main.ignore("#{config.root}/lib/omni_auth")

and issue a require call from the initializer.

Not saying this solves the whole situation, but for starters it fixes something.

[fxn]

I need to read this with some time, but let me ask a couple of questions:

1. Who defines OmniAuth::Strategies::ShieldOIDC?
2. The provider call in the initializer is setting up Rack middleware, right?

[fragkakis]

Hello Xavier, thank you.

1. It is a custom strategy within our repository.
2. Yes, this is my understanding of how omniauth works.

[fxn]

Is OmniAuth::Strategies::ShieldOIDC defined in a directory that belongs to the autoload paths?

[fragkakis]

It is defined in lib/omni_auth/strategies/shield_oidc.rb, and the autoload paths from application.rb are the following:

    config.autoload_paths += %W[
      #{config.root}/app/models/serializable
      #{config.root}/app/models/concerns
      #{config.root}/lib
      #{config.root}/demo
      #{config.root}/qa
      #{config.root}/app/mailers/concerns
    ]

[fragkakis]

I have a workaround, but it doesn't seem the right. I added the following require statements (with the specific order, so that when application_record is loaded the two dependencies have already been loaded). I also removed the reference to the Member constant in my lib/shield_settings.rb.

# config/initializers/omniauth.rb
# ... other require statements
require "concerns/fine_grained_validations"
require "concerns/policy_scope_support"
require "application_record"

If you have any other insights, I will appreciate it if you chime in. Thank you.

[fxn]

OK, we need to polish a bit more.

No reloadable code should be loaded while the application is booting. The file lib/shield_settings.rb is still reloadable, because lib is in the autoload paths. Since the middleware uses the contants defined there, you need to tell the autoloader this file has to be ignored as well:

Rails.autoloaders.main.ignore("#{config.root}/lib/shield_settings.rb")

Let's iterate until we reach a more controlled setup to address the issue with the migrations.

Ideally, no warning should be issued. This section of the upgrdading guide has some tips, but I am here to help you anyway ❤️.

[fxn]

Since this is something related to how the Rails application is configured, I have moved the issue to the Rails repository (rails/rails#49310).

[eileencodes]

I am pretty sure that the connection closed issue is fixed by rails/rails#45450 but it can't be backported to 7-0-stable because it's too big of a change in internal behavior. Upgrading to 7.1.x should fix that particular issue.