GithubHelp home page GithubHelp logo

Comments (5)

hanseltime avatar hanseltime commented on May 29, 2024 1

This would be great to have! Especially since Chrome doesn't allow me to control canary releases for an extension and I need a staging extension for QA.

I do think the issue described and the solution might need a little adjustment though. I would propose:

  1. We have a branch/prereleaseOverride section in the config
{
  "plugins": [
    [
      "semantic-release-chrome",
      {
        "extensionId": "mppjhhbajcciljocgbadbhbgphjfdmhj",
        "asset": "my-extension.zip",
        "prereleaseConfig": {
           "alpha": {
               "extensionId": "my-alpha-extension-id",
           },
           "beta": {
               "extensionId": "my-beta-extension-id",
           },  
        }.
      }
    ],
    [
      "@semantic-release/github",
      {
        "assets": ["my-extension.zip"]
      }
    ]
  ]
}

The above config feels a little safer to me. If I hard-coded the extension id and added "allowPrerelease", then I could technically still release to my prod extension from my prerelease branch. If we added the ability to configure prerelease channel configs (and then throw errors on any prerelease branch that doesn't have a config), then the releaser has to be sure they are specifying the correct extension.

Also, I think for prerelease, we don't want to scrub the 4th number. That would lead to weird spots where we release 2 or 3 prereleases that are all 1.0.1 and only the first one can release. Looking at the Chrome extension versioning name, it looks like we could just remove the non-numerical prerelease name (like alpha or beta) and just release that number.

Source: https://developer.chrome.com/docs/extensions/reference/manifest/version

from semantic-release-chrome.

RupertBarrow avatar RupertBarrow commented on May 29, 2024 1

It would be great for this plugin to update the "version_name" field in the manifest.json with the "standard" version name normally generated by semantic-release, such as "1.0.0-alpha.1"

from semantic-release-chrome.

nate-pratt avatar nate-pratt commented on May 29, 2024

Pull request for this issue can be found here - #112

from semantic-release-chrome.

RupertBarrow avatar RupertBarrow commented on May 29, 2024

Yes.
For prerelease, I would certainly expect a 4-number version number such as 1.0.0.1

from semantic-release-chrome.

envil avatar envil commented on May 29, 2024

It would be great for this plugin to update the "version_name" field in the manifest.json with the "standard" version name normally generated by semantic-release, such as "1.0.0-alpha.1"

Exactly, "version_name" can be used exclusively for prerelease.

from semantic-release-chrome.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.