HTTPX Timeout setting not synced w/ Orthanc setting about pyorthanc

[gacou54]

Hi @jrkerns ,

That's an excellent point, we should be able to change the timeout of a RemoteModality. I think it would be better if the Orthanc class had a timeout parameter, so every call made with the client instance would use the timeout. I actually plan to add all the httpx.Client parameters in the Orthanc.__init__() for the next release (hopefully next week). Then, this would work:

orthanc = Orthanc('url', 'username', 'password', timeout=300)
modality = RemoteModality(orthanc, 'mymodality')

# Now all orthanc and modality calls should have the 300 s timeout 

For now, this should do the trick since Orthanc inherited from httpx.Client:

orthanc = Orthanc('url', 'username', 'password')
orthanc.timeout = 300
modality = RemoteModality(orthanc, 'mymodality')

[gacou54]

Hi @Kiechlus,

PR #26 is ongoing, I hope to release the new pyorthanc version this week. In the meantime, this should work

orthanc = Orthanc('url', 'username', 'password')
orthanc.timeout = 300  # Set the timeout

# now use orthanc as you would ordinary
orthanc.get_patients()
...

Thank you for your interest to make pyorthanc better!

[jrkerns]

Thanks, that's definitely easy. I ended up overriding .post :

class MyOrthanc(Orthanc):

   def post(*args, **kwargs):
        return super().post(*args, **kwargs, timeout=300)

but I like your solution more.

[Kiechlus]

I have the same problem, need to set the httpx timout because the default is much too short. Hope this will be released soon. Thanks a lot!

[gacou54]

timeout added in #26