Make target file extension configurable about create-index

[jogelin]

It is also useful for typescript but it doesn't generate index.TS...

[gajus]

By the looks of it, this change would affect only a few lines of code:

./src/utilities/readDirectory.js:36:        return !_.includes(files, fileName + '.js');
./src/utilities/readDirectory.js:67:        if (!isDirectory && !_.endsWith(fileName, '.js')) {

As long as this feature is implemented sticking to principles of functional programming (without use or global state variables and tested), I don't have any objections against a PR.

[gausie]

I figured I would just replace with fileName.matches(/\.jsx?$/)
On 19 Mar 2016 11:05, "Gajus Kuizinas" [email protected] wrote:

By the looks of it, this change would affect only a few lines of code:

./src/utilities/readDirectory.js:36: return !.includes(files, fileName + '.js');
./src/utilities/readDirectory.js:67: if (!isDirectory && !.endsWith(fileName, '.js')) {

As long as this feature is implemented sticking to principles of
functional programming (without use or global state variables and tested),
I don't have any objections against a PR.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#6 (comment)

[gajus]

No, that could have unwanted side-effects, e.g. someone could have Foo.js as entry file and Foo.jsx to contain a template. Not saying it is a good thing to do, but I have seen worse and it is a fairly likely scenario.

[Someguy123]

What's the status of this? @gajus ?

Would be great to just do --filetype=jsx, or if it would just natively do JSX by default.

[gajus]

What's the status of this? @gajus ?

Not a priority for me. Will happily accept a PR.

[gajus]

It is also useful for typescript but it doesn't generate index.TS...

Would accept a PR.

[FDiskas]

already implemented