Encoding lists without space leaks about cereal

[elliottt]

I like the idea of doing the chunked representation. I don't really see any problem with exposing both a chunked version of putListOf/getListOf, in addition to one that picks a sane default value. If you're interested in writing the patch, I'd be happy to take the contribution :)

[Gabriella439]

I'd be happy to write up the patch. Just give me a while because I need to familiarize myself with the cereal internals some more first.

[elliottt]

You should be able to write it as something that makes iterated calls to putListOf/getListOf as a primitive, looping over its input and splitting at the chunk boundary using splitAt.

putChunkedListOf :: Int -> Putter a -> Putter [a]
putChunkedListOf clen f = loop
  where
  loop xs = do
    let (as,bs) = splitAt clen xs
    putListOf f as
    unless (null bs) (loop bs)

[Gabriella439]

Yeah, I wasn't going to do it exactly the way I wrote it. That was just
something I threw together for an example. Hand-writing the chunking
would also let me inline the code for marking the last chunk.

On 08/20/2012 02:19 PM, Trevor Elliott wrote:

You should be able to write it as something that makes iterated calls
to putListOf/getListOf as a primitive, looping over its input and
splitting at the chunk boundary using splitAt.

putChunkedListOf :: Int -> Putter a -> Putter [a]
putChunkedListOf clen f = loop
where
loop xs = do
let (as,bs) = splitAt clen xs
putListOf f as
unless (null bs) (loop bs)

—
Reply to this email directly or view it on GitHub
#6 (comment).

[elliottt]

(I'm closing this as it seems like you'll submit a pull request when the feature is ready :)

[Gabriella439]

Yeah, I will submit a pull request when it is ready.