Comments (6)
I'm glad that you're finding it a useful library :)
The easiest way to implement this would be some additional bookkeeping in the state of the Get monad, though I'm not sure what the performance implications of that would be. If you'd like to experiment, I'd be happy to accept a patch.
I like the idea of bytesWritten, and could see that being invaluable when rendering out data. We've been contemplating a rewrite of the Put monad, so this could be a good opportunity to add that in!
from cereal.
Thank you for the quick response.
I may submit a patch. I looked at the Get code earlier; but I was not sure if it would be better to add an argument to the Get type or to add another field to the Incomplete constructor of the More type.
In the meantime I have my own code set up using StateT to track a byte offset counter, which I am incrementing by hand. It works fine - but requires careful testing to make sure that my bookkeeping is correct. Which is some motivation for me to work on a patch.
from cereal.
I think that adding another field to the Result
structure would probably be the way to go. I hadn't realized how close binary and cereal had gotten, so we could basically mirror their Decoder structure in our Result type.
from cereal.
(I'm closing this as it looks like you'll submit a pull request when this feature is ready :)
from cereal.
@hallettj two years late, but have you come up with anything for this? I would like bytesRead
as well (mostly so I can add it to ekmett/bytes for both Binary and Cereal). I might try to give it a go, but if you have something laying around, I don't want to duplicate effort.
Alternatively if @elliottt has any more advice on how to go about this, that would be useful ;) - not sure what all (if anything) has changed since the comments above, or if they still apply.
from cereal.
Not much has changed since my previous comments, and I think the recommendations still make sense. If you come up with something that works well, I'm happy to look it over :)
from cereal.
Related Issues (20)
- Support for Decimal128 HOT 1
- I can't just get the result and Builder out of Put. HOT 1
- Missing `Serialize` instance for `NonEmpty a` HOT 1
- Build error HOT 10
- Request for new release HOT 2
- Missing base Serialize instances: Identity, Const
- Upload GHC-8.8.1 changes to Hackage HOT 1
- Question about Generic serialiazation/deserialization, Not a bug (a priori) HOT 4
- [Question] Are serializations portable to other machines? HOT 2
- gPut depends on the nesting structure of :+:
- Missing getters for Int putters
- lookAhead and bytesRead HOT 2
- doc issue HOT 2
- Missing `instance Serialize Void`
- Cannot be built with GHC 9.2.0.20210821 HOT 2
- Deserialization of Ratios with 0 denominator
- Export an `eof` getter that spits out the remaining bytestring HOT 5
- Build failure with GHC 9.4 HOT 3
- combining isEmpty with many causes an internal error HOT 2
- fails to build with ghc-9.6.3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cereal.