Script fails when using together with Turbolinks about tiny-slider

[ganlanyuan]

Hi, I will take a look maybe tomorrow.

[S1SYPHOS]

Much appreciated. Turbolinks / ajax-like javascript in general are becoming a thing.
Since, as you may have noticed, I like tns, seeing them married would be great!

[ganlanyuan]

I see.

1. I didn't see container in options, are you using default .slider?
2. And do all pages using the same structure (container and controlsContainer)?

According to turbolinks:

turbolinks:load fires once after the initial page load, and again after every Turbolinks visit. Access visit timing metrics with the event.data.timing object.
General idea:

1. Can you try just initiate tns once?
2. Before every Turbolinks visit, you may need run slider.destroy() to remove eventListeners, clean some memory.
3. Since slider is supposed to change, it's better to use let.

[S1SYPHOS]

Alright, way to go! Will check this out, more soon, thanks for the fast reply 🍰

[S1SYPHOS]

Deleting window.onload + slider() function call from turbolink:load event did the trick, although I'm a little confused. Thanks anyway for the hint to load it just once 👍

[ganlanyuan]

Hi, the function getSlideEdges in version 1 requests that the slides be loaded before the initialization. But I will update it later to make it work better with dynamically loaded content.
Version 2 doesn't have this issue.

Regardless of version, to initiate tns more than 1 times will probably make troubles.

Thanks for letting me know your case anyway.

[S1SYPHOS]

The honour was mine!