Comments (8)
There is no concern, if you read the call stack you will see it can't get an invalid int. If int64_t
was always a concern it wouldn't have been added.
from garlicoin.
is relying on the call stack beneficial for efficiency? I'm still just a student so I'm trying to gauge why you wouldn't just change it to a unsigned int, does it make more sense to restrict the functions parameters instead of relying on the call stack to return a legitimate value? (again im a student so bear with me if what i'm saying makes no sense)
from garlicoin.
Honestly, I don't know, it's not my code- it's from the reference lyra2 implementation. You'd have to ask them why they chose this.
from garlicoin.
the code I diffed is from the lyra2.c core implementation, so maybe there was some change between the docs? I know its annoying but can you shoot me that link to the ref docs before we call this issue closed?
from garlicoin.
I'll find tomorrow, it's later here.
from garlicoin.
https://github.com/vertcoin/vertcoin-old/blob/master/src/Lyra2RE/Lyra2.c#L46
Quick reference to the vertcoin Lyra2, for comparison
from garlicoin.
Well that's vertcoins implementation not the reference implementation
from garlicoin.
This is a none issue. The function you are referring can't be passed anything other than 32 bytes look here and you will see why https://github.com/GarlicoinOrg/Garlicoin/blob/master/src/crypto/allium/allium.c#L59.
from garlicoin.
Related Issues (20)
- Reserve bip44
- Tesnet hard fork to Allium PoW
- Litecoin remnants in Win_Wallet HOT 1
- [QT] When viewing a transaction's details, the "From" field always says "unknown"
- Fix references to bitcoin etc in QT client. HOT 1
- Not able to add custom label per-transaction, changes all labels for that address
- Update checkpoints
- Remove SCRIPT_ADDRESS
- Avoid slow transaction search
- Merge upstream 0.16 Litecoin HOT 1
- Remove CI building and add Gitian release builds HOT 1
- Feature: yak type messages in Garlicoin wallet HOT 1
- CVE-2018-17144
- BUG: Build Fails -> using gcc 11.1.1
- ./install_db4.sh fails on Apple Silicon HOT 1
- GUI Fails to Build on macOS Monterey ARM
- Unit tests fail; expected values are from Litecoin HOT 1
- Regtest fails to assert the genesis block hash
- Error: Transaction too large for fee policy HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from garlicoin.