GithubHelp home page GithubHelp logo

Comments (3)

gatkin avatar gatkin commented on May 23, 2024

Good catch, we're definitely missing tests for unicode handling. To fix this, I think it would be best to create a failing test here for the issue, and then we will probably have to fix the unicode handling when reading XML data from a file in parse_from_file(). Most likely, it will probably be best to just use the ElementTree.parse function to read the file data and let ElementTree handle unicode for us.

I can probably get to this within the next week or two and push out a new release to PyPi, but if you are able to open a pull request with the fix, that would be great as well!

from declxml.

marnunez avatar marnunez commented on May 23, 2024

Ohh alright, trust ET.parse to pick up the right encoding from the XML header, right? And fallback to utf-8 if missing, I assume. I made a few fast modifications, I need some results for a project I'm working on (the urgent never leaves time for the important, right?), so I ended up adding the encoding as an optional parameter. Nevertheless, I would leave something like this as an option too, in case of a wrongly formatted XML.
First time dealing with the infamous Unicode pain. Hopefully the last one!

from declxml.

gatkin avatar gatkin commented on May 23, 2024

Resolved in #10

from declxml.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.