Comments (11)
@gazorby Awesome! That fixed it for me
from fish-abbreviation-tips.
Sorry for the delay!
I'm not able to reproduce, do you still have this issue? Also, does it occurs only with gws
and glg
abbreviations?
from fish-abbreviation-tips.
Hi @gazorby thanks for following up.
I still have the issue presently. It not only happens with the git abbreviations but with any abbreviation.
I added a zipped screen recording to showcase the issue.
From the looks of it if you wait for a second or two after expanding the abbreviation the hint is not shown.
If you are fast and you hit enter after expanding the abbreviation it will incorrectly suggest you should have used an abbreviation.
from fish-abbreviation-tips.
Thanks for the detail, your problem looks pretty weird. Do you have any other fish plugins installed? If so, i suggest you uninstall them and keep only fish-abbreviation-tips to see if there would be any potential overlap.
from fish-abbreviation-tips.
fish-abbreviation-tips has bindings to space and newline to detect if an abbreviation was used, if you have another fish plugin overriding some of these bindings, it could be the cause of the bug.
from fish-abbreviation-tips.
I'm having the same problem, it happens with all of my abbreviations, not just git ones. Checked the key bindings also, space & enter are properly bound to __abbr_tips_bind_space
and __abbr_tips_bind_newline
from fish-abbreviation-tips.
This has been happening to me recently as well. Not sure if it's a coincidence but it seemed to have coincided with when I upgraded to fisher 4
from fish-abbreviation-tips.
Any news on this? I'm still unable to reproduce this issue.
I even tried in a clean ubuntu:latest
docker container and didn't notice any wrong suggestion.
Can you try cleaning your fisher environment and only reinstalling abbreviation-tips?
Before reinstalling, ensure the following variables are removed:
__abbr_tips_used
__abbr_tips_run_once
__ABBR_TIPS_VALUES
__ABBR_TIPS_KEYS
ABBR_TIPS_PROMPT
ABBR_TIPS_AUTO_UPDATE
ABBR_TIPS_ALIAS_WHITELIST
ABBR_TIPS_REGEXES
Also make sure these functions doesn't exist anymore:
__abbr_tips_init
__abbr_tips_bind_newline
__abbr_tips_bind_space
__abbr_tips
If all of the above is gone then you should be in a clean environment.
from fish-abbreviation-tips.
I've checked that all the variables/functions were removed. Been a while since I've used this plugin but it appears that it only happens with abbr (aliases seem to work fine) e.g. for abbr g -> git
- type
g<Space>status<CR>
- abbr tip shows
I have a bunch of plugins installed so when I have the chance, I'll test it with just abbr tips
from fish-abbreviation-tips.
I can confirm this is happening for me as well.
I have a single abbreviation defined in config.fish
:
# Abbreviations
if status --is-interactive
# Git
abbr --add --global gs "git status"
end
I'm using the status --is-interactive
conditional as it's described in the docs: https://fishshell.com/docs/current/cmds/abbr.html#internals
Though this might not be ideal because I had to run __abbr_tips_init
manually for the abbreviation tip to show.
Edit: I've just tested adding a new abbreviation interactively via abbr --add gf "git fetch"
instead and that also didn't show up without me running __abbr_tips_init
manually, not even closing all instances of fish and restarting.
So I'm not sure what the "best practice" would be here (I just started giving fish a try after using zsh for years, so I'm not really familiar with it yet).
It doesn't matter if I run git status
or gs
, the abbreviation tip will be shown in both cases.
Using fish version 3.2.1
on Arch Linux.
Other plugins installed are:
- jorgebucaran/fisher (plugin manager)
- mattgreen/lucid.fish (prompt)
from fish-abbreviation-tips.
@alexanderjeurissen, @novadev94 @petertriho, @mserajnik a fix has been merged to enable bindings when using vi mode, can you update the plugin and check if it's fixed?
from fish-abbreviation-tips.
Related Issues (17)
- [Feature] : Add support for aliases
- Error on alias -s HOT 1
- Doesn't do anything on fresh install
- Don't show tips when history is used HOT 3
- `__abbr_tips_init` not running automatically HOT 3
- Didn't show tips for plugin-git HOT 1
- Problems with install HOT 2
- Weird buggy behavior HOT 5
- Regex matching
- Only works for abbr but not for alias & function?
- None of the abbreviations work HOT 2
- Does not work for aliases defined inside fish scripts
- Doesn't work at all for me HOT 7
- Getting abbr: invalid option -- -q as installing with fisher HOT 2
- print abbr list HOT 1
- Lots of output when I use command line HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fish-abbreviation-tips.