Comments (2)
The third item is very quickly gonna be noticed by simply the build failing. I don't think you need to do much more with regards to that, other than either making a descriptive error, or expecting the builder to dig into the code for it (as I did, long enough to know that it wasn't gonna be a simple sed
:))
from pandocs.
That special configuration is needed can be made obvious, sure; however, that the option exists at all may be less so! It seems likely to me that a packager will sooner reach for patch -p0
than digging through the configuration.
Then there's the issue of detection; I'd assume that ".git
does not exist" should be the correct basis, but maybe I'm missing something?
Additionally, you remarked via IM that we ought to pass the --git-dir
argument to git show
to ensure that we don't accidentally pick up a parent Git dir. (I'm not sure if that plays nice with submodules, but my intuition says that it should.)
As for the patch, well, I think patch
is indeed more appropriate than sed
, yes :P
But you will have to update that patch now that #513 has landed.
from pandocs.
Related Issues (20)
- Undocumented SGB Hardware quirk: Command packet bytes are buffered
- a11y: add alt text and check if the existing ones are descriptive enough
- Mention MBC30 in MBC3 documentation HOT 1
- Make "single" page self-referential
- Markup is not allowed in admonitions titles HOT 1
- Contributing: document how to export SVGs
- Open external links in a new tab
- Build reproducibility: pull fonts from npm HOT 3
- Make single-page and PDF version more visible HOT 4
- Hardware register default value doesn't make sense on DMG for CGB-only registers HOT 4
- Serial transfer is re-described in the interrupts page
- Make bits-description table separations more visible HOT 5
- Vram map - suggestion
- "Timer Obscure Behavior" needs an overhaul HOT 1
- Average loading time is > 8 seconds HOT 2
- SGB command packet transfers are described using wrong bits of JOYP HOT 1
- 0xFF0F - Interrupt flag, not mentioned in memory layout HOT 2
- Registers "default return values" no longer mentioned HOT 2
- Port "Gameboy sound hardware" from the old wiki
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pandocs.