GithubHelp home page GithubHelp logo

Allow building out-of-tree about pandocs HOT 2 CLOSED

ISSOtm avatar ISSOtm commented on May 27, 2024 2
Allow building out-of-tree

from pandocs.

Comments (2)

mid-kid avatar mid-kid commented on May 27, 2024

The third item is very quickly gonna be noticed by simply the build failing. I don't think you need to do much more with regards to that, other than either making a descriptive error, or expecting the builder to dig into the code for it (as I did, long enough to know that it wasn't gonna be a simple sed :))

from pandocs.

ISSOtm avatar ISSOtm commented on May 27, 2024

That special configuration is needed can be made obvious, sure; however, that the option exists at all may be less so! It seems likely to me that a packager will sooner reach for patch -p0 than digging through the configuration.

Then there's the issue of detection; I'd assume that ".git does not exist" should be the correct basis, but maybe I'm missing something?

Additionally, you remarked via IM that we ought to pass the --git-dir argument to git show to ensure that we don't accidentally pick up a parent Git dir. (I'm not sure if that plays nice with submodules, but my intuition says that it should.)

As for the patch, well, I think patch is indeed more appropriate than sed, yes :P
But you will have to update that patch now that #513 has landed.

from pandocs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.