Comments (4)
It gets worse: look at all the different sections that get mapped to $0018
.
gb240p.map
gb240p.sym
from rgbds.
I set up a bisection
# set the boundaries
git checkout master
git bisect start
make clean && make -j3
# build libbet in other terminal
git bisect bad
git checkout v0.7.0
# HEAD is detached
make clean && make -j3
# build libbet in other terminal
git bisect good
In the other terminal, I was running this command
make clean && make -j3 libbet.gb RGBDS=/home/pino/develop/assemblers/rgbds/ && sameboy libbet.gb
Result: #1323 broke it
446fb07fd5ea651557ef86eb54b5f93f06a204dd is the first bad commit
commit 446fb07fd5ea651557ef86eb54b5f93f06a204dd
Author: Sylvie <[email protected]>
Date: Fri Mar 1 16:21:29 2024 -0500
Use `std::deque<std::vector>` for free space (#1323)
Log:
# status: waiting for both good and bad commits
# bad: [846a9411b9ea0676bdc4b7dc6ac89c98020af8af] Refactor `FileStackNode::dump` to not need a helper function
git bisect bad 846a9411b9ea0676bdc4b7dc6ac89c98020af8af
# status: waiting for good commit(s), bad commit known
# good: [08f3e360c9525b65291db9cee66fc5eb6e4a45e4] Release v0.7.0
git bisect good 08f3e360c9525b65291db9cee66fc5eb6e4a45e4
# good: [962398969bfe492e10b92205641800b70af63bd6] Use `std::string` for `PURGE` args
git bisect good 962398969bfe492e10b92205641800b70af63bd6
# bad: [ba183e900b4550d2040c5e255bef27c8b8861ee8] Update contributors
git bisect bad ba183e900b4550d2040c5e255bef27c8b8861ee8
# good: [eff8c324c8547c476f29cb49585cc9f47541b0fe] Remove now-unnecessary `struct` keyword (#1320)
git bisect good eff8c324c8547c476f29cb49585cc9f47541b0fe
# bad: [dbcb82799e197cd247e03df4a34b97cc8e0ab95d] Use `std::vector` for capture buffer
git bisect bad dbcb82799e197cd247e03df4a34b97cc8e0ab95d
# bad: [701b926288959be18f881ad919ce61580701ec59] Use RAII `std::string` and `std::vector` in randtilegen (#1325)
git bisect bad 701b926288959be18f881ad919ce61580701ec59
# good: [e14ba664ea5615d18ff22c3054311d204ba81315] Remove redundant `(void)` parameter declarations
git bisect good e14ba664ea5615d18ff22c3054311d204ba81315
# bad: [446fb07fd5ea651557ef86eb54b5f93f06a204dd] Use `std::deque<std::vector>` for free space (#1323)
git bisect bad 446fb07fd5ea651557ef86eb54b5f93f06a204dd
# good: [1ac3c0262f16076b289a61535d924cac38bd1bee] Refactor structs to use methods instead of functions (#1322)
git bisect good 1ac3c0262f16076b289a61535d924cac38bd1bee
# first bad commit: [446fb07fd5ea651557ef86eb54b5f93f06a204dd] Use `std::deque<std::vector>` for free space (#1323)
from rgbds.
anyone want to debug that?
from rgbds.
or, does anyone have a minimal example that gives a different ROM after that commit? My tests with a few floating sections are still the same (although the .sym file is sorted differently/wrongly).
from rgbds.
Related Issues (20)
- why can't charmaps be 16-bit HOT 5
- Why canβt use newer 7.0version in nix HOT 3
- Security vulnerability through fuzzing HOT 1
- Allow a color in an inline palette spec to be `none`
- Make sure rgbasm and rgblink report "`<stdin>`" or "`<stdout>`" for `-` as appropriate
- Missing contributing documentation
- INCHARMAP doesn't always produce correct output HOT 1
- Refactoring and style cleanup with C++ HOT 3
- Don't `#include <stdbool.h>`
- Accept multiple exported constants if they agree on a value HOT 3
- Run `strip` on binaries before publishing them
- Associate sizes with labels, and add a new way to delimit those sizes HOT 3
- CI should verify ROM hashes for all projects
- .sym files are not sorted in ascending order
- Fix CI with Ubuntu 22.04 HOT 3
- `\@` in an `INCLUDE`d file increments at its EOF unless inherited from a parent context HOT 1
- Performance improvements for C++
- math.asm test failure with armv7a-unknown-linux-gnueabihf HOT 6
- can't build HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rgbds.