The filter function 'not' flag does not work if used in the Data Schema about gaffer

[p013570]

Probably best to remove the not flag from FilterFunction and create a Not filter function that wraps a FilterFunction and inverts the result.

[p013570]

Migration steps

The not flag on FilterFunction has been removed. So if you were using this in a data schema, store schema or view then you will need to wrap your function inside a Not filter function.

For example:

in json

"filter": {
  "functions": [
    {
      "function": {
        "class": "gaffer.function.simple.filter.Not",
        "function": {
          "class": "gaffer.function.simple.filter.IsEqual",
          "value": "user02"
        }
      },
      "selection": [
        {
          "key": "userId"
        }
      ]
    }
  ]
}

in java using a view builder

.filter(new ElementFilter.Builder()
  .select(Property.USER_ID)
  .execute(new Not(new IsEqual("user02")))
  .build())

Any custom filter functions will also need to be migrated to implement the method

public boolean isValid(final Object[] input);

instead of

protected boolean _isValid(final Object[] input);

There also are classes FilterFunctionTest, AggregateFunctionTest and TransformFunctionTest that should be extended when writing tests for any custom functions.

[p013570]

Merged into develop