Comments (4)
Thanks for your report.
The maximum of 32 for maxChoice
is currently defined here:
cuetools.net/CUETools.Processor/CUESheet.cs
Line 3017 in 33f922e
The following line later on in the code is responsible for not showing the list of found images, when there are more than 32:
cuetools.net/CUETools.Processor/CUESheet.cs
Line 3040 in 33f922e
Which behavior do you expect or how many images should be the maximum in your case?
from cuetools.net.
"How many?" is hard question to answer. I don't have the time to analyze the code for any performance impacts that might result from too large a number. Someone more familiar with the code should make that decision. Does there actually need to be a limit? Was that a decision made back when 1024x768 was the standard screen size and $500 computers didn't have quad-core, 3 GHz processors and terabyte storage?
I have, so far, 288 WAV/CUE/JPG file sets in the folder structure below. As time goes on, I have to keep splitting folders so that I can do encodings with CueTools. In my experience as a programmer, I have found that whenever software sets a limit, there is someone that exceeds it. Whatever the limit is, if it is exceeded, there should be some messaging to the user about what happened and how to work around it. Silent, mystery behavior is aggravating, and it makes folks walk away.
As long as the list of image names is alphabetized, I'd think that 128 or 256 image names would be manageable. But even at 256, if I had all my files in one folder, I still would have run into the problem, and it would probably have been harder to figure out.
RipCUE
+-A
+-B
+-C
+-DEF
+-GHI
+-JK
+-L
+-M
+-NOPQ
+-RS
+-TUVWXYZ
+-Various
+-Zappa
+-Zappa, Frank 1
+-Zappa, Frank 2
+-Zappa, Frank 3
+-Zappa, Frank 4
+-Zappa, Frank Singles
+-Zappa, Frank YCDTOSA
+-Zappa-Beat the Boots
+-Zappa-Beefheart
+-Zappa-Mothers
Thank you for taking the time to look into this. I appreciate it, at least from the point of knowing that it's not me :-) !
Sincerely,
Dan
from cuetools.net.
Dear Dan,
thanks for the feedback.
I did some tests in the meantime with 9999 jpg files in the folder and subfolders of a cue sheet.
The following info shows the memory consumption from Windows task manager and the time it took to analyze:
1.) image file size each: 22.8 KB (250x250) 16.4 MB CUETools started Go Analyzing input file... (1 min 2 s) 461.1 MB Select best match (online album) 463.0 MB Select best match (album art) 2.) image file size each: 197 KB (571x571) 16.4 MB CUETools started Go Analyzing input file... (1 min 40 s) 3382.7 MB Select best match (online album) 3391.8 MB Select best match (album art) CPU: i7-3687U, nothing special SSD Path length of each image file: 113 characters
Remark: the current limit of 32 was rather coming from a typical situation of having just one ore a few images inside an album folder.
So I guess, the maxChoice
limit can be increased. What I see from your message above is, that 512
would be sufficient for your number of images. And if there are lots of images (thousands) in the folder of the cue sheet and its subfolders: display an info message and still allow to choose an image.
Best regards
Wolfgang
from cuetools.net.
Cool, thanks. I'll keep an eye out for the new release!
from cuetools.net.
Related Issues (20)
- [Feature Request] Add option to skip verifying when a matching ctdb/ar entry cannot be found HOT 1
- Generated CUE file format problem HOT 1
- When EAC log(s) are consolidated in single logfile, CUETools only compares against 1st entry HOT 1
- Japanese character handling. HOT 2
- File path generation giving a space chr at end of "artist"\ HOT 3
- Mode294 does not work on GH22LS51 HOT 2
- [REQ] FLAC v1.4.3 HOT 1
- CUETools - Full-size images downsized to 300px HOT 1
- Errors ripping with LG's HL-DT-ST WH10LS30 in "Auto" C2 error mode, suspected mode294 unsupported HOT 1
- cover art download
- Latest MusicBrainz metadata not fetched by CTDB HOT 2
- Error when ripping CD with LG Drive [HL-DT-ST DVDRAM GP65NB60 RF01]. "Exception: Error reading CD: medium error: UNRECOVERED READ ERROR HOT 3
- [REQ] "fix" repo's license files HOT 1
- Object reference not set to an instance of an object.. HOT 7
- Add support for AIFF HOT 6
- [2.2.4] FLAC decoding issue with ffmpeg plugin HOT 1
- [QUESTION] Time for a new release or? HOT 2
- Docker
- HTOA file shifts filenames in cue sheet HOT 2
- Found a file that causes crash of encoder at certain settings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cuetools.net.