GithubHelp home page GithubHelp logo

Comments (2)

bzuillsmith avatar bzuillsmith commented on June 18, 2024

Oh, you're right, this function will run to the end of the entity. I never needed to implement anything 3D so I didn't test or think about that.

Yeah, those could really be moved out to the entity. We just need to identify all the codes that are possible on the vertices section (if there are more than what's there already). Then the default case in this switch you posted could stop parsing the vertices and return without advancing the scanner.

Do you want to give that a try and submit a PR?

As for the OCS to world stuff, I wrote three-dxf which uses three.js under the hood. Not sure, but maybe Three.js will take care of that for you (assuming you are able to use it in your project).

from dxf-parser.

kpetrow avatar kpetrow commented on June 18, 2024

Maybe just return on default case?

I also use three js. Three would handle it if you put the lines in parent object then rotate the parent, but I need a 2d drawing and don't want to have to rely on three js libs for canvas drawing. I found some c code that I could port over... I'll look through the 3dxf code. I have some tricks iplemented for large dxf files, and would love to pick up any optimizations you have.

I'll do a PR tomorrow. Thanks

from dxf-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.