GithubHelp home page GithubHelp logo

Comments (5)

kantenkugel avatar kantenkugel commented on June 2, 2024 1

that above PR from kevin looks much better than my ugly code and I also did a lot of other stuff for my personal use so i didn't want to make a PR out of that directly. Wanted to see what the opinion on it is first.

from react-snapshot.

kantenkugel avatar kantenkugel commented on June 2, 2024

I figured out that this problem has to do with the "homepage" field in the package.json file. If the field is not present, it renders as normal, but with homepage field present, it fails with above error.

As I need the homepage field for my builds (react page hosted under sub-folder of domain), it would be nice if this could be fixed

from react-snapshot.

kantenkugel avatar kantenkugel commented on June 2, 2024

I have written a quick proof of concept that works for me (using the public-path): https://gist.github.com/kantenkugel/aee4d827d51e43ff9f1feb3709c0830b

from react-snapshot.

Cooke avatar Cooke commented on June 2, 2024

I have also run into this limitation. If you (@kantenkugel) have a solution can you not create a PR?

from react-snapshot.

kantenkugel avatar kantenkugel commented on June 2, 2024

Closing issue as this is now implemented in 1.0.5-0. Would be nice to publish to npm tho as the npm registry still has 1.0.4 as its current version

from react-snapshot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.