GithubHelp home page GithubHelp logo

Comments (10)

strican avatar strican commented on June 26, 2024 1

Another point is that a user cannot pass in their own config file currently - you get the error can not mix '--config' with arguments [apiserver-advertise-address kubernetes-version pod-network-cidr]. If we used a config, users can override the config and have a baseline config template to copy from and add to.

from ansible-role-kubernetes.

geerlingguy avatar geerlingguy commented on June 26, 2024

(Same thing in 1.11... and 1.12 was just released.)

from ansible-role-kubernetes.

stale avatar stale commented on June 26, 2024

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

from ansible-role-kubernetes.

stale avatar stale commented on June 26, 2024

This issue is no longer marked for closure.

from ansible-role-kubernetes.

stale avatar stale commented on June 26, 2024

This issue is no longer marked for closure.

from ansible-role-kubernetes.

rdxmb avatar rdxmb commented on June 26, 2024

As I understand it, we need to create a config-file and set --config <FILE> within the kubelet_args_line. Is this correct? Is there an idea to which path we deploy that config-file?

from ansible-role-kubernetes.

rdxmb avatar rdxmb commented on June 26, 2024

also: I think it would help to create the config file from the templates in the ansible-role instead of lineinfiles like it is in https://github.com/geerlingguy/ansible-role-kubernetes/blob/master/tasks/kubelet-setup.yml

Are there any plans doing that - or doing it in a completely different way?

from ansible-role-kubernetes.

rdxmb avatar rdxmb commented on June 26, 2024

Could we overwrite the line
Environment="KUBELET_CONFIG_ARGS=--config=/var/lib/kubelet/config.yaml"
in /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
to something like
Environment="KUBELET_CONFIG_ARGS=--config=/etc/kubernetes/kubelet-config.yaml"

and generate /etc/kubernetes/kubelet-config.yaml from template?

I think this would be the easiest way to parse variables to this file - as we can just parse them as 1:1 with jinja2-templates.

If you think this is a good way I could try to create a PR for that.

from ansible-role-kubernetes.

geerlingguy avatar geerlingguy commented on June 26, 2024

That would be a good idea, yes, but likely it will break existing usage of the role, so it would need to be done in a major version bump or have some backwards compatibility added.

from ansible-role-kubernetes.

rdxmb avatar rdxmb commented on June 26, 2024

Ok, I started to create a PR like discussed above and started testing on my local machine.
However, I've just found, that the kubeletConfiguration can (and should?) be passed with using kubeadm init. See
Does anybody know if this is only for the croup driver? Do we want to use --config with kubeadm init or just with kubectl ?

What do you think?

Edit: Here is the link

https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#configure-cgroup-driver-used-by-kubelet-on-control-plane-node

Or is this just for the cgroup-driver?

... confused ...

Edit again:

Seems like we need to use that with kubeadm init.

Links:

from ansible-role-kubernetes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.