GithubHelp home page GithubHelp logo

Comments (10)

geerlingguy avatar geerlingguy commented on June 19, 2024 1

This is fixed via the merged PR now. Thanks!

from ansible-role-varnish.

andrewhowdencom avatar andrewhowdencom commented on June 19, 2024

There is both a systemd service unit and a sysvinit bash script. I think ansible might be enabling the bash script somehow, by precedence.

from ansible-role-varnish.

andrewhowdencom avatar andrewhowdencom commented on June 19, 2024

Moving the sysvinit script out the way means the systemd service is enabled on boot. Just gonna try it the other way

from ansible-role-varnish.

andrewhowdencom avatar andrewhowdencom commented on June 19, 2024

Perhaps related: ansible/ansible#22303

from ansible-role-varnish.

andrewhowdencom avatar andrewhowdencom commented on June 19, 2024

Potential workaround: ansible/ansible-modules-core#3764 (comment)

from ansible-role-varnish.

andrewhowdencom avatar andrewhowdencom commented on June 19, 2024

Might be resolved by #65. Just testing.

from ansible-role-varnish.

andrewhowdencom avatar andrewhowdencom commented on June 19, 2024

Yah it worked. Using our fork for now -- if this gets merged in, awesome. <3

from ansible-role-varnish.

geerlingguy avatar geerlingguy commented on June 19, 2024

Thanks for the PR! I left a couple review notes.

from ansible-role-varnish.

andrewhowdencom avatar andrewhowdencom commented on June 19, 2024

Hola! Thanks for getting back to me. I've amended the review, and am running a test build now as a sanity check (though I have used this syntax previously).

As a design note, would you consider adding a .yamllint file to the top of your repo? This would make code style nits such as EOL easier to catch in future

from ansible-role-varnish.

andrewhowdencom avatar andrewhowdencom commented on June 19, 2024

Booted fine

from ansible-role-varnish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.