go.rice vs. go test -coverprofile about go.rice

[GeertJohan]

Hi brian,

Can you share the code that you use to test?

/GeertJohan

[bfallik]

Unfortunately I can't, it's not open source. I can try to come up with a smaller test case or help answer any specific questions you might have.

I just uncovered another data point. If I compile the test binary (go test -c pkgname) and then run it (./src/pkgname/pkgname.test) I encounter the same panic. Since the backtraces are the same I suspect that the -coverprofile flag causes similar behavior to go test -c pkgname && ./src/pkgname/pkgname.test.

brian

[GeertJohan]

I think the error that results in a panic is from this call: https://github.com/GeertJohan/go.rice/blob/master/box.go#L55

Probably the runtime.Caller(3) frame returns a path that doesn't exist anymore because it was temporarily created for the test build. Maybe we can detect this and resolve the correct path?

Buy you're saying it also fails when you embed the code in go source.. This is strange, because then the panic should not occur. Is it possible that the panic or failure occuring with rice embed-ed version is different from the one you posted?

[bfallik]

Interesting.

It does seem like the panic() is caused by stat() since the error text is "panic: stat datastore/_test/_obj_test/sql: no such file or directory".

I'm not exactly sure how to provide more info. It's possible I saw different panics but I'm not able to differentiate them now. If I remove the embedded code (rm src/pkgname/*.sql-box.go) I still see the same error. Is there a way to determine if rice is using the embedded data vs. the local files? Is there a way to force it to use one or the other?

I wonder if I should add some debugging code to findBox() to see what's going on?

brian

[bfallik]

Geert-Johan,

I've added some print debugging to findBox() and it seems like len(embedded.EmbeddedBoxes) is always 0, so I'm a bit confused. I'm running 'rice embed' inside the package dir, which generates a file sql.rice-box.go that seems to contain the binary data. I would expect 'go test' to embed the contents of this file automatically since it's just go source code but I can't find any evidence of that.

[GeertJohan]

Can you try renaming to sql_rice-box.go? I think it's not recognizing the source file for test..

[GeertJohan]

In which case I'll update rice to use underscore instead of dot.. I have already been thinking about that recently.. So please let me know if that works.

[bfallik]

No, that didn't work either. I even tried renaming the file to box.go.

Any suggestions on how to debug this further? Can I inspect the binary to see which boxes are embedded? Can I debug the build process to understand why the generated code doesn't seem to be included?

[bfallik]

OK, I've determine this issue is in our build. I believe it's related to how we're vendoring our third-party dependencies. Feel free to close this issue if you'd like.

[GeertJohan]

Okay :)