zip command is required for appending to binary about go.rice

[tgulacsi]

A better (copy from archive/zip) is available at github.com/tgulacsi/go/zipA .

[tehbilly]

I'm curious as to why this fails fast on Windows instead of checking to see if the command is even available? This is trivial to implement using os/exec#LookPath. However, I think that the suggestion to use a purely go implementation of zipping resources as provided by the example is the way to go.

[sanderhahn]

Adding a new method to the writer.go source gives you the possibility to have a pure Go version. See the example patch done in https://github.com/sanderhahn/gozip

[GeertJohan]

Do you think that patch can be merged into the stdlib? @sanderhahn

[sanderhahn]

Maybe :-)

Just filed an issue so that they could take this into consideration:
https://code.google.com/p/go/issues/detail?id=8669

2014-09-05 21:18 GMT+02:00 Geert-Johan Riemer [email protected]:

Do you think that patch can be merged into the stdlib?

—
Reply to this email directly or view it on GitHub
#7 (comment).

Sander Hahn
06-14211335
[email protected]

[GeertJohan]

This is now issue golang/go#8669
@sanderhahn do you want to proceed to propose this change to go's stdlib? Or should I?

[sanderhahn]

Hey Geert-Johan, the issue is marked accepted maybe for 1.5, but there are
no changes in the archive/writer.go on master. If you want to re-propose
the issue again: that is okay :-) Best regards, Sander

[GeertJohan]

Sorry, I meant to post the actual change in the review process. If you want I can do it, but you'd need to sign off because of copyright, I think..

[sanderhahn]

Hmm i only copied the constructor and added the parameter. Don't know if
such a small change can have copyright... but hereby i provide this
addition to be free in the open for anyone to use ;-) How do i sign off
copyright?

[GeertJohan]

Ok I'll submit it.

[sanderhahn]

Issue has been resolved in Go 1.5: golang/go#8669

Now you can use:

    w := zip.NewWriter(f)
    w.SetOffset(startoffset)

Example is in the Zip function in gozip.go