web-coding-challenge's Introduction

Web Coding Challenge

The coding challenge is optional if you already have some code that you're proud of and can share with us.

Coding Challenge Requirements

How we review

Your application will be reviewed by at least two of our engineers. We do take into consideration your experience level.

We value quality over feature-completeness. It is fine to skip certain features aside provided you mention them out in your project's README.

The aspects of your code we will review include:

Architecture: how clean is the separation between the front-end and the back-end?
Code quality: is the code simple, easy to understand, and maintainable? Are there any code smells or other red flags? Does object-oriented code follows principles such as the single responsibility principle? Is the coding style consistent with the language's guidelines? Is it consistent throughout the codebase?
Version Control: are you commiting early and often ? how good are your git commit messages ?
Correctness: does the application do what was asked? If there is anything missing, does the README explain why it is missing?

Useful links

Useful links can be found here.

That’s it ! May the force be with you !! 🖖

web-coding-challenge's Issues

The Mockup photos are not accurate concerning the pages they represent

Good evening,

My name is Youssef El Habchi, I am a recent participant of the Hidden founders web coding challenge.

As I was just about to send my repository, I've noticed that the Mockup photos of the project challenge at the Coding Challenge Guidelines page are not accurate.

I took my a while to figure out, since i started my project 3 days ago.

I think they should be flipped to remove any further confusion by future participants.

Duplicate shops in dump

There are some duplicate shops in the dump file

for example

(mongo) > db.shops.find({ name: 'Filodyne' }).pretty()

results to

{
	"_id" : ObjectId("5a0c6b42fd3eb67969316d82"),
	"picture" : "http://placehold.it/150x150",
	"name" : "Filodyne",
	"email" : "[email protected]",
	"city" : "Rabat",
	"location" : {
		"type" : "Point",
		"coordinates" : [
			-6.747,
			33.98196
		]
	}
}
{
	"_id" : ObjectId("5a0c6b2dfd3eb67969316d6e"),
	"picture" : "http://placehold.it/150x150",
	"name" : "Filodyne",
	"email" : "[email protected]",
	"city" : "Rabat",
	"location" : {
		"type" : "Point",
		"coordinates" : [
			-6.747,
			33.98196
		]
	}
}

gemography / web-coding-challenge Goto Github PK