Comments (4)
dalehenrich
commented on August 23, 2024
There are only a handful of senders of halt in Rowan and these should be cleaned up (obviously none of them are sent as a result of the current test suite):
RwGsImagePatchVisitor>>visitPropertiesModification:
RwGsImagePatchVisitor>>visitSourceModification:
RwGsPackageSymbolDictionary>>addClassAssociation:forClass:toPackageNamed:
RwPackageModification>>addModificationToPatchSet:inPackage:
The rest of the offenders are in the base, GLASS or tODE and can be ignored, since we won't be shipping Rowan in 3.2.15 with GLASS or tODE installed ...
from rowan.
ericwinger
commented on August 23, 2024
Sounds good.
from rowan.
dalehenrich
commented on August 23, 2024
unclosing so that we will make a sanity check before shipping to make sure that Rowan self halts are removed
from rowan.
dalehenrich
commented on August 23, 2024
halts in Rowan code have been eliminated ...
from rowan.
Related Issues (20)
- Create RowanSample9V2 and RowanSample9V3 repositories ...
- (v3.0) RwPrjBrowserToolV2>>moveClassNamed:toPackage: does not convert class category correctly ... HOT 1
- (V3.0) Arrange to split out v2, v3, and common tests into separate loadable components to allow parallel test runs
- (V2.3) 'Encountered an existing association for a new class JsonPetitParser' during rowanConvTest (3.7.0) HOT 1
- (v2.3) looks like class category is not being auditted ...
- (v3.0) Class>>category: is not protected from package convention violations
- (v3.0) remove Rowan class creation methods that include constraints argument ....
- (v3.0) Module>>changeNameTo: needs to have a Rowan implementation
- (v3.0) class audit should compare name of loaded class against class name
- (v3.0) RwModificationCypressFamilyWriterVisitor vs. RwModificationCypressFamilyWriterVisitorV2
- Contradictory error report HOT 4
- [Feature Request] Allow extensions to augment class definition
- Walkback with (possibly) misleading error message when saving a method in a hybrid category HOT 6
- (v2) tonel parser doesn't deal well with comments containint $[ embedded in a selector
- Should be able to remove a *'d category not associated with a package
- Patches for a project not on disk gives walkback
- ArgumentError Unicode disallowed in string comparison while compiling method with unicode string HOT 4
- Pool dictionaries should be available, preferably displayed in the class creation template HOT 5
- (v2.5) need to support Rowan upgrades to v2.5
- (v3.0) expose topazFileHeader and topazFileFooter in RwProject and RwResolvedProjectV2 #exportTopazFormatTo:logClassCreation:excludeClassInitializers:excludeRemoveAllMethods:usingPackageNamesMap:
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rowan.